Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some file upload issues #16

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

johanbrandhorst
Copy link
Contributor

@johanbrandhorst johanbrandhorst commented Dec 2, 2019

runtimes/podman: recursively create dirs

Recursively create directories for any uploaded
files, should they not already exist.

Note that this is still broken, subject to #12.

Recursively create directories for any uploaded
files, should they not already exist.

runtimes/podman: use silly file permissions

This works around some permission errors

Add file mode to File

Recursively create directories for any uploaded
files, should they not already exist.
This works around some permission errors
@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #16 into master will decrease coverage by 0.85%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #16      +/-   ##
=========================================
- Coverage   41.96%   41.1%   -0.86%     
=========================================
  Files           6       6              
  Lines         336     343       +7     
=========================================
  Hits          141     141              
- Misses        157     164       +7     
  Partials       38      38
Impacted Files Coverage Δ
runtimes/podman/file.go 0% <0%> (ø) ⬆️
runtimes/docker/file.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0ff35...0df91bb. Read the comment docs.

@johanbrandhorst johanbrandhorst changed the title runtimes/podman: recursively create dirs Fix some file upload issues Dec 2, 2019
@johanbrandhorst johanbrandhorst merged commit bbcc212 into master Dec 2, 2019
@johanbrandhorst johanbrandhorst deleted the recursively-create-missing-dirs branch December 2, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants