Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error grading status #438

Merged
merged 1 commit into from
Jul 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions course_grader_vue/components/section/primary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,12 @@
<template v-else>
<h3 :id="sectionNameId">{{ section.display_name }}</h3>
</template>
<div v-if="section.grading_status">
{{ section.grading_status }}
</div>
<div v-else>{{ gradingStatusText }}</div>
<div>{{ gradingStatusText }}</div>
</div>
<div v-if="section.secondary_sections && section.secondary_sections.length">
<ul>
<li v-for="secondary in section.secondary_sections" :key="secondary.section_id">
<secondary-section :section="secondary" :gradingStatus="gradingStatus"></secondary-section>
<li v-for="(secondary, index) in section.secondary_sections" :key="secondary.section_id">
<secondary-section :section="secondary" :grading-status="secondaryStatus[index]"></secondary-section>
</li>
</ul>
</div>
Expand Down Expand Up @@ -44,40 +41,44 @@ export default {
formatLinkTitle,
};
},
computed: {
gradingStatusText() {
if (this.section.grading_status) {
return this.section.grading_status;
} else if (this.errorStatus) {
return this.errorStatus;
} else {
return this.formatGradingStatus(this.gradingStatus);
}
},
routerLinkTitle() {
return this.formatLinkTitle(this.gradingStatus);
},
},
data() {
return {
gradingStatus: [],
gradingStatus: {},
secondaryStatus: [],
errorStatus: "",
sectionNameId: "section-name-" + this.section.section_id,
gradingStatusText: "",
routerLinkTitle: "",
};
},
methods: {
applyGradingStatus: function (grading_status) {
this.gradingStatusText = this.formatGradingStatus(grading_status);
this.routerLinkTitle = this.formatLinkTitle(grading_status);

// Add secondary statusus to prop
if (grading_status.hasOwnProperty("secondary_sections")) {
this.gradingStatus = grading_status.secondary_sections;
}
},
loadSectionStatus: function () {
if (this.section.status_url) {
this.getSectionStatus(this.section.status_url).then(response => {
return response.data;
}).then(data => {
this.applyGradingStatus(data.grading_status);
this.gradingStatus = data.grading_status;
this.secondaryStatus = data.grading_status.secondary_sections;
}).catch(error => {
console.log(error.message);
this.errorStatus = error.message;
});
}
},
},
created() {
if (!this.section.grading_status) {
this.loadSectionStatus();
}
this.loadSectionStatus();
},
};
</script>
50 changes: 28 additions & 22 deletions course_grader_vue/components/section/secondary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@
<template v-else>
<h3 :id="sectionNameId">{{ section.display_name }}</h3>
</template>
<div v-if="section.grading_status">
{{ section.grading_status }}
</div>
<div v-else>{{ gradingStatusText }}</div>
<div>{{ gradingStatusText }}</div>
</div>
</template>

Expand All @@ -27,6 +24,7 @@ export default {
},
gradingStatus: {
type: Object,
default: {},
},
},
setup() {
Expand All @@ -36,42 +34,50 @@ export default {
formatLinkTitle,
};
},
computed: {
gradingStatusText() {
if (this.section.grading_status) {
return this.section.grading_status;
} else if (this.errorStatus) {
return this.errorStatus;
} else if (this.section.status_url) {
return this.formatGradingStatus(this.secondaryStatus);
} else {
return this.formatGradingStatus(this.gradingStatus);
}
},
routerLinkTitle() {
if (this.section.status_url) {
return this.formatLinkTitle(this.secondaryStatus);
} else {
return this.formatLinkTitle(this.gradingStatus);
}
},
},
data() {
return {
secondaryStatus: {},
errorStatus: "",
sectionNameId: "section-name-" + this.section.section_id,
gradingStatusText: "",
routerLinkTitle: "",
};
},
methods: {
applyGradingStatus: function (grading_status) {
this.gradingStatusText = this.formatGradingStatus(grading_status);
this.routerLinkTitle = this.formatLinkTitle(grading_status);
},
loadSectionStatus: function () {
if (this.section.status_url) {
this.getSectionStatus(this.section.status_url).then(response => {
return response.data;
}).then(data => {
this.applyGradingStatus(data.grading_status);
this.secondaryStatus = data.grading_status;
}).catch(error => {
console.log(error.message);
this.errorStatus = error.message;
});
} else {
// Check for a grading status in the prop
let grading_status = this.gradingStatus.find((gs) =>
gs.section_id === this.section.section_id
);
if (grading_status) {
this.applyGradingStatus(grading_status);
}
return this.gradingStatus;
}
},
},
created() {
if (!this.section.grading_status) {
this.loadSectionStatus();
}
this.loadSectionStatus();
},
};
</script>
2 changes: 1 addition & 1 deletion course_grader_vue/utils/grading-status.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function formatGradingStatus(data) {
}
}
}
return "No submission information";
return "";
}

export {
Expand Down