Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reported issues in Ace #127

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Fixing reported issues in Ace #127

merged 1 commit into from
Jan 22, 2019

Conversation

jayashreemohan29
Copy link
Member

@jayashreemohan29 jayashreemohan29 commented Jan 21, 2019

  1. Nested mode bug arises when the range of files that you could fsync/fdatasync includes a 'None' option. This could happen if we don't return the right parent/sibling of all involved files.

When we added a new nested directory A/C we missed out updating what it's sibling is, which therefore returned 'None'. This was included in the list of files that could be persisted, throwing a None type error. So the fix was to return the right sibling.

Whenever a new level of nesting, file or directory is added to Ace, ensure that you update their parent and sibling in the definitions Parent() and SiblingOf().

  1. The other change was in copy_diff.sh, where we could erroneously display that the test could not be run, although it completed successfully. This would occur if there were multiple empty diff files as reported by report two Ace bugs #126. Fix this by changing how we check for the existence of empty diff files.

@jayashreemohan29
Copy link
Member Author

Updated the comment above.

@jayashreemohan29 jayashreemohan29 merged commit aa80c0f into master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants