Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Modify Cypress error attribute checks #296

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Sep 13, 2024

The recent change in Lagoon uselagoon/lagoon#3736 removed attributes from error messages.

This PR removes the explicit check for these attributes from the Cypress response checks.
It also fixes the KEYCLOAK variable references to match the latest changes in main.

Copy link
Contributor

@DaveDarsa DaveDarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tobybellwood tobybellwood merged commit f655ba8 into main Sep 13, 2024
4 checks passed
@tobybellwood tobybellwood deleted the cypress_noattribute branch September 13, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants