Ianvnorrisusds/1531 fix docker quickstart #2137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanNorrisUSDS
requested review from
vim-usds and
mattbowen-usds
as code owners
|
@IanNorrisUSDS, are you seeing any of these pipeline checks failing locally? |
TODO probably should move openpyxl to a non dev dependency since its essential to the ETL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1531
Describe the bug
Was attempting to follow the quick start guide and noticed this issue which is a similar problem in terms of it being "quick" for folks unfamiliar to docker (needing to know to run docker-compose build before up).
Also modified the dockerfile to get the data server running, and noticed an annoying thing with port 5000 (future todo: change it away from port 5000 or make configurable?) so added that to the readme as well.