Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1803: percent of zips (WIP) #1916

Open
wants to merge 96 commits into
base: main
Choose a base branch
from

Commits on Aug 10, 2022

  1. Configuration menu
    Copy the full SHA
    218fa48 View commit details
    Browse the repository at this point in the history
  2. Imputing income using geographic neighbors (#1559)

    Imputes income field with a light refactor. Needs more refactor and more tests (I spotchecked). Next ticket will check and address but a lot of "narwhal" architecture is here.
    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f680d86 View commit details
    Browse the repository at this point in the history
  3. Adding HOLC indicator (#1579)

    Added HOLC indicator (Historic Redlining Score) from NCRC work; included 3.25 cutoff and low income as part of the housing burden category.
    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    3a96001 View commit details
    Browse the repository at this point in the history
  4. Update backend for Puerto Rico (#1686)

    * Update PR threshold count to 10
    
    We now show 10 indicators for PR. See the discussion on the github issue for more info: #1621
    
    * Do not use linguistic iso for Puerto Rico
    
    Closes 1350.
    
    Co-authored-by: Shelby Switzer <[email protected]>
    2 people authored and emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    2e38aaa View commit details
    Browse the repository at this point in the history
  5. updating

    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    92d68ba View commit details
    Browse the repository at this point in the history
  6. Do not drop Guam and USVI from ETL (#1681)

    * Remove code that drops Guam and USVI from ETL
    
    * Add back code for dropping rows by FIPS code
    
    We may want this functionality, so let's keep it and just make the constant currently be an empty array.
    
    Co-authored-by: Shelby Switzer <[email protected]>
    2 people authored and emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f8a6567 View commit details
    Browse the repository at this point in the history
  7. Emma nechamkin/holc patch (#1742)

    Removing HOLC calculation from score narwhal.
    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    002cddf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e98282d View commit details
    Browse the repository at this point in the history
  9. Rescaling linguistic isolation (#1750)

    Rescales linguistic isolation to drop puerto rico
    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    29419dd View commit details
    Browse the repository at this point in the history
  10. adds UST indicator (#1786)

    adds leaky underground storage tanks
    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    daf188c View commit details
    Browse the repository at this point in the history
  11. Changing LHE in tiles to a boolean (#1767)

    also includes merging / clean up of the release
    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    bbb5bbc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    cac1e04 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    19d3bde View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3aa03f1 View commit details
    Browse the repository at this point in the history
  15. first run through

    emma-nechamkin committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    ed9b717 View commit details
    Browse the repository at this point in the history
  16. Refactor DOE Energy Burden and COI to use YAML (#1796)

    * added tribalId for Supplemental dataset (#1804)
    
    * Setting zoom levels for tribal map (#1810)
    
    * NRI dataset and initial score YAML configuration (#1534)
    
    * update be staging gha
    
    * NRI dataset and initial score YAML configuration
    
    * checkpoint
    
    * adding data checks for release branch
    
    * passing tests
    
    * adding INPUT_EXTRACTED_FILE_NAME to base class
    
    * lint
    
    * columns to keep and tests
    
    * update be staging gha
    
    * checkpoint
    
    * update be staging gha
    
    * NRI dataset and initial score YAML configuration
    
    * checkpoint
    
    * adding data checks for release branch
    
    * passing tests
    
    * adding INPUT_EXTRACTED_FILE_NAME to base class
    
    * lint
    
    * columns to keep and tests
    
    * checkpoint
    
    * PR Review
    
    * renoving source url
    
    * tests
    
    * stop execution of ETL if there's a YAML schema issue
    
    * update be staging gha
    
    * adding source url as class var again
    
    * clean up
    
    * force cache bust
    
    * gha cache bust
    
    * dynamically set score vars from YAML
    
    * docsctrings
    
    * removing last updated year - optional reverse percentile
    
    * passing tests
    
    * sort order
    
    * column ordening
    
    * PR review
    
    * class level vars
    
    * Updating DatasetsConfig
    
    * fix pylint errors
    
    * moving metadata hint back to code
    
    Co-authored-by: lucasmbrown-usds <[email protected]>
    
    * Correct copy typo (#1809)
    
    * Add basic test suite for COI (#1518)
    
    * Update COI to use new yaml (#1518)
    
    * Add tests for DOE energy budren (1518
    
    * Add dataset config for energy budren (1518)
    
    * Refactor ETL to use datasets.yml (#1518)
    
    * Add fake GEOIDs to COI tests (#1518)
    
    * Refactor _setup_etl_instance_and_run_extract to base (#1518)
    
    For the three classes we've done so far, a generic
    _setup_etl_instance_and_run_extract will work fine, for the moment we
    can reuse the same setup method until we decide future classes need more
    flexibility --- but they can also always subclass so...
    
    * Add output-path tests (#1518)
    
    * Update YAML to match constant (#1518)
    
    * Don't blindly set float format (#1518)
    
    * Add defaults for extract (#1518)
    
    * Run YAML load on all subclasses (#1518)
    
    * Update description fields (#1518)
    
    * Update YAML per final format (#1518)
    
    * Update fixture tract IDs (#1518)
    
    * Update base class refactor (#1518)
    
    Now that NRI is final I needed to make a small number of updates to my
    refactored code.
    
    * Remove old comment (#1518)
    
    * Fix type signature and return (#1518)
    
    * Update per code review (#1518)
    
    Co-authored-by: Jorge Escobar <[email protected]>
    Co-authored-by: lucasmbrown-usds <[email protected]>
    Co-authored-by: Vim <[email protected]>
    4 people committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    9635ef5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Update etl_score_geo.py

    Yikes! Fixing merge messup!
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    d55b7c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    485a9a8 View commit details
    Browse the repository at this point in the history
  3. Imputing income using geographic neighbors (#1559)

    Imputes income field with a light refactor. Needs more refactor and more tests (I spotchecked). Next ticket will check and address but a lot of "narwhal" architecture is here.
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f047ca9 View commit details
    Browse the repository at this point in the history
  4. Adding HOLC indicator (#1579)

    Added HOLC indicator (Historic Redlining Score) from NCRC work; included 3.25 cutoff and low income as part of the housing burden category.
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1782d02 View commit details
    Browse the repository at this point in the history
  5. Update backend for Puerto Rico (#1686)

    * Update PR threshold count to 10
    
    We now show 10 indicators for PR. See the discussion on the github issue for more info: #1621
    
    * Do not use linguistic iso for Puerto Rico
    
    Closes 1350.
    
    Co-authored-by: Shelby Switzer <[email protected]>
    2 people authored and emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    05748c9 View commit details
    Browse the repository at this point in the history
  6. updating

    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b41a287 View commit details
    Browse the repository at this point in the history
  7. Do not drop Guam and USVI from ETL (#1681)

    * Remove code that drops Guam and USVI from ETL
    
    * Add back code for dropping rows by FIPS code
    
    We may want this functionality, so let's keep it and just make the constant currently be an empty array.
    
    Co-authored-by: Shelby Switzer <[email protected]>
    2 people authored and emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3071815 View commit details
    Browse the repository at this point in the history
  8. Emma nechamkin/holc patch (#1742)

    Removing HOLC calculation from score narwhal.
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7559cf4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ab24c6 View commit details
    Browse the repository at this point in the history
  10. Rescaling linguistic isolation (#1750)

    Rescales linguistic isolation to drop puerto rico
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f6efdd4 View commit details
    Browse the repository at this point in the history
  11. adds UST indicator (#1786)

    adds leaky underground storage tanks
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b0a7284 View commit details
    Browse the repository at this point in the history
  12. Changing LHE in tiles to a boolean (#1767)

    also includes merging / clean up of the release
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0d90ae5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8c75190 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    15450cf View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4f6a1b5 View commit details
    Browse the repository at this point in the history
  16. first run through

    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    baa591a View commit details
    Browse the repository at this point in the history
  17. Refactor DOE Energy Burden and COI to use YAML (#1796)

    * added tribalId for Supplemental dataset (#1804)
    
    * Setting zoom levels for tribal map (#1810)
    
    * NRI dataset and initial score YAML configuration (#1534)
    
    * update be staging gha
    
    * NRI dataset and initial score YAML configuration
    
    * checkpoint
    
    * adding data checks for release branch
    
    * passing tests
    
    * adding INPUT_EXTRACTED_FILE_NAME to base class
    
    * lint
    
    * columns to keep and tests
    
    * update be staging gha
    
    * checkpoint
    
    * update be staging gha
    
    * NRI dataset and initial score YAML configuration
    
    * checkpoint
    
    * adding data checks for release branch
    
    * passing tests
    
    * adding INPUT_EXTRACTED_FILE_NAME to base class
    
    * lint
    
    * columns to keep and tests
    
    * checkpoint
    
    * PR Review
    
    * renoving source url
    
    * tests
    
    * stop execution of ETL if there's a YAML schema issue
    
    * update be staging gha
    
    * adding source url as class var again
    
    * clean up
    
    * force cache bust
    
    * gha cache bust
    
    * dynamically set score vars from YAML
    
    * docsctrings
    
    * removing last updated year - optional reverse percentile
    
    * passing tests
    
    * sort order
    
    * column ordening
    
    * PR review
    
    * class level vars
    
    * Updating DatasetsConfig
    
    * fix pylint errors
    
    * moving metadata hint back to code
    
    Co-authored-by: lucasmbrown-usds <[email protected]>
    
    * Correct copy typo (#1809)
    
    * Add basic test suite for COI (#1518)
    
    * Update COI to use new yaml (#1518)
    
    * Add tests for DOE energy budren (1518
    
    * Add dataset config for energy budren (1518)
    
    * Refactor ETL to use datasets.yml (#1518)
    
    * Add fake GEOIDs to COI tests (#1518)
    
    * Refactor _setup_etl_instance_and_run_extract to base (#1518)
    
    For the three classes we've done so far, a generic
    _setup_etl_instance_and_run_extract will work fine, for the moment we
    can reuse the same setup method until we decide future classes need more
    flexibility --- but they can also always subclass so...
    
    * Add output-path tests (#1518)
    
    * Update YAML to match constant (#1518)
    
    * Don't blindly set float format (#1518)
    
    * Add defaults for extract (#1518)
    
    * Run YAML load on all subclasses (#1518)
    
    * Update description fields (#1518)
    
    * Update YAML per final format (#1518)
    
    * Update fixture tract IDs (#1518)
    
    * Update base class refactor (#1518)
    
    Now that NRI is final I needed to make a small number of updates to my
    refactored code.
    
    * Remove old comment (#1518)
    
    * Fix type signature and return (#1518)
    
    * Update per code review (#1518)
    
    Co-authored-by: Jorge Escobar <[email protected]>
    Co-authored-by: lucasmbrown-usds <[email protected]>
    Co-authored-by: Vim <[email protected]>
    4 people authored and emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    97e1754 View commit details
    Browse the repository at this point in the history
  18. Update etl_score_geo.py

    Yikes! Fixing merge messup!
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    94cdc47 View commit details
    Browse the repository at this point in the history
  19. fixing rebase

    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    dcda155 View commit details
    Browse the repository at this point in the history
  20. updated to fix linting errors (#1818)

    Cleans and updates base branch
    emma-nechamkin committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    481a2a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Configuration menu
    Copy the full SHA
    13e7908 View commit details
    Browse the repository at this point in the history
  2. Add FUDS ETL (#1817)

    * Add spatial join method (#1871)
    
    Since we'll need to figure out the tracts for a large number of points
    in future tickets, add a utility to handle grabbing the tract geometries
    and adding tract data to a point dataset.
    
    * Add FUDS, also jupyter lab (#1871)
    
    * Add YAML configs for FUDS (#1871)
    
    * Allow input geoid to be optional (#1871)
    
    * Add FUDS ETL, tests, test-datae noteobook (#1871)
    
    This adds the ETL class for Formerly Used Defense Sites (FUDS). This is
    different from most other ETLs since these FUDS are not provided by
    tract, but instead by geographic point, so we need to assign FUDS to
    tracts and then do calculations from there.
    
    * Floats -> Ints, as I intended (#1871)
    
    * Floats -> Ints, as I intended (#1871)
    
    * Formatting fixes (#1871)
    
    * Add test false positive GEOIDs (#1871)
    
    * Add gdal binaries (#1871)
    
    * Refactor pandas code to be more idiomatic (#1871)
    
    Per Emma, the more pandas-y way of doing my counts is using np.where to
    add the values i need, then groupby and size. It is definitely more
    compact, and also I think more correct!
    
    * Update configs per Emma suggestions (#1871)
    
    * Type fixed! (#1871)
    
    * Remove spurious import from vscode (#1871)
    
    * Snapshot update after changing col name (#1871)
    
    * Move up GDAL (#1871)
    
    * Adjust geojson strategy (#1871)
    
    * Try running census separately first (#1871)
    
    * Fix import order (#1871)
    
    * Cleanup cache strategy (#1871)
    
    * Download census data from S3 instead of re-calculating (#1871)
    
    * Clarify pandas code per Emma (#1871)
    mattbowen-usds committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d5fbb80 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d6c04b1 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'emma-nechamkin/release/score-narwhal' of https://github…

    ….com/usds/justice40-tool into emma-nechamkin/release/score-narwhal
    vim-usds committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9321798 View commit details
    Browse the repository at this point in the history
  5. Adding DOT composite to travel score (#1820)

    This adds the DOT dataset to the ETL and to the score. Note that currently we take a percentile of an average of percentiles.
    emma-nechamkin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ebac552 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Adding first street foundation data (#1823)

    Adding FSF flood and wildfire risk datasets to the score.
    emma-nechamkin committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5e378ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    981a36c View commit details
    Browse the repository at this point in the history
  3. Add abandoned mine lands data (#1824)

    * Add notebook to generate test data (#1780)
    
    * Add Abandoned Mine Land data (#1780)
    
    Using a similar structure but simpler apporach compared to FUDs, add an
    indicator for whether a tract has an abandonded mine.
    
    * Adding some detail to dataset readmes
    
    Just a thought!
    
    * Apply feedback from revieiw (#1780)
    
    * Fixup bad string that broke test (#1780)
    
    * Update a string that I should have renamed (#1780)
    
    * Reduce number of threads to reduce memory pressure (#1780)
    
    * Try not running geo data (#1780)
    
    * Run the high-memory sets separately (#1780)
    
    * Actually deduplicate (#1780)
    
    * Add flag for memory intensive ETLs (#1780)
    
    * Document new flag for datasets (#1780)
    
    * Add flag for new datasets fro rebase (#1780)
    
    Co-authored-by: Emma Nechamkin <[email protected]>
    mattbowen-usds and emma-nechamkin committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    49623e4 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'emma-nechamkin/release/score-narwhal' of github.com:usd…

    …s/justice40-tool into emma-nechamkin/release/score-narwhal
    emma-nechamkin committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2e05b1d View commit details
    Browse the repository at this point in the history
  5. Adding NLCD data (#1826)

    Adding NLCD's natural space indicator end to end to the score.
    emma-nechamkin committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    7d89d41 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    88dc2e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Add donut hole calculation to score (#1828)

    Adds adjacency index to the pipeline. Requires thorough QA
    mattbowen-usds committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    6e41e0d View commit details
    Browse the repository at this point in the history
  2. Adding eamlis and fuds data to legacy pollution in score (#1832)

    Update to add EAMLIS and FUDS data to score
    emma-nechamkin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    cb4866b View commit details
    Browse the repository at this point in the history
  3. Update to use new FSF files (#1838)

    backend is partially done!
    emma-nechamkin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    3ba1c62 View commit details
    Browse the repository at this point in the history
  4. Quick fix to kitchen or plumbing indicator

    Yikes! I think I messed something up and dropped the pctile field suffix from when the KP score gets calculated. Fixing right quick.
    emma-nechamkin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    1ee26bf View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Fast flag update (#1844)

    Added additional flags for the front end based on our conversation in stand up this morning.
    emma-nechamkin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    d892bce View commit details
    Browse the repository at this point in the history
  2. Tiles fix (#1845)

    Fixes score-geo and adds flags
    emma-nechamkin committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    ad1ce2b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6385c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Issue 1827: Add demographics to tiles and download files (#1833)

    * Adding demographics for use in sidebar and download files
    lucasmbrown-usds committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4bf7773 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    6418335 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    637b8c3 View commit details
    Browse the repository at this point in the history
  2. fix markdown

    esfoobar-usds committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    d3efcbd View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. tuple type

    esfoobar-usds committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    e539db8 View commit details
    Browse the repository at this point in the history
  2. Score tests (#1847)

    * update Python version on README; tuple typing fix
    
    * Alaska tribal points fix (#1821)
    
    * Bump mistune from 0.8.4 to 2.0.3 in /data/data-pipeline (#1777)
    
    Bumps [mistune](https://github.com/lepture/mistune) from 0.8.4 to 2.0.3.
    - [Release notes](https://github.com/lepture/mistune/releases)
    - [Changelog](https://github.com/lepture/mistune/blob/master/docs/changes.rst)
    - [Commits](lepture/mistune@v0.8.4...v2.0.3)
    
    ---
    updated-dependencies:
    - dependency-name: mistune
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    
    * poetry update
    
    * initial pass of score tests
    
    * add threshold tests
    
    * added ses threshold (not donut, not island)
    
    * testing suite -- stopping for the day
    
    * added test for lead proxy indicator
    
    * Refactor score tests to make them less verbose and more direct (#1865)
    
    * Cleanup tests slightly before refactor (#1846)
    
    * Refactor score calculations tests
    
    * Feedback from review
    
    * Refactor output tests like calculatoin tests (#1846) (#1870)
    
    * Reorganize files (#1846)
    
    * Switch from lru_cache to fixture scorpes (#1846)
    
    * Add tests for all factors (#1846)
    
    * Mark smoketests and run as part of be deply (#1846)
    
    * Update renamed var (#1846)
    
    * Switch from named tuple to dataclass (#1846)
    
    This is annoying, but pylint in python3.8 was crashing parsing the named
    tuple. We weren't using any namedtuple-specific features, so I made the
    type a dataclass just to get pylint to behave.
    
    * Add default timout to requests (#1846)
    
    * Fix type (#1846)
    
    * Fix merge mistake on poetry.lock (#1846)
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: Jorge Escobar <[email protected]>
    Co-authored-by: Jorge Escobar <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Matt Bowen <[email protected]>
    Co-authored-by: matt bowen <[email protected]>
    6 people committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    1c4d3e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. just testing that the boolean is preserved on gha (#1867)

    * updated with hopefully a fix; coercing aml, fuds, hrs to booleans for the raw value to preserve null character.
    emma-nechamkin committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    b0b7ff0 View commit details
    Browse the repository at this point in the history
  2. Adding tests to ensure proper calculations (#1871)

    * just testing that the boolean is preserved on gha
    * checking drop tracts works
    * adding a check to the agvalue calculation for nri
    * updated with error messages
    emma-nechamkin committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    5201f9e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. tribal tiles fix (#1874)

    * Alaska tribal points fix (#1821)
    
    * tribal tiles fix
    
    * disabling child opportunity
    
    * lint
    
    * removing COI
    
    * removing commented out code
    esfoobar-usds committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ccd72e2 View commit details
    Browse the repository at this point in the history
  2. Pipeline tile tests (#1864)

    * temp update
    
    * updating with fips check
    
    * adding check on pfs
    
    * updating with pfs test
    
    * Update test_tiles_smoketests.py
    
    * Fix lint errors (#1848)
    
    * Add column names test (#1848)
    
    * Mark tests as smoketests (#1848)
    
    * Move to other score-related tests (#1848)
    
    * Recast Total threshold criteria exceeded to int (#1848)
    
    In writing tests to verify the output of the tiles csv matches the final
    score CSV, I noticed TC/Total threshold criteria exceeded was getting
    cast from an int64 to a float64 in the process of PostScoreETL. I
    tracked it down to the line where we merge the score dataframe with
    constants.DATA_CENSUS_CSV_FILE_PATH --- there where > 100 tracts in the
    national census CSV that don't exist in the score, so those ended up
    with a Total threshhold count of np.nan, which is a float, and thereby
    cast those columns to float. For the moment I just cast it back.
    
    * No need for low memeory (#1848)
    
    * Add additional tests of tiles.csv (#1848)
    
    * Drop pre-2010 rows before computing score (#1848)
    
    Note this is probably NOT the optimal place for this change; it might
    make more sense for each source to filter its own tracts down to the
    acceptable tract list. However, that would be a pretty invasive change,
    where this is central and plenty of other things are happening in score
    transform that could be moved to sources, so for today, here's where the
    change will live.
    
    * Fix typo (#1848)
    
    * Switch from filter to inner join (#1848)
    
    * Remove no-op lines from tiles (#1848)
    
    * Apply feedback from review, linter (#1848)
    
    * Check the values oeverything in the frame (#1848)
    
    * Refactor checker class (#1848)
    
    * Add test for state names (#1848)
    
    * cleanup from reviewing my own code (#1848)
    
    * Fix lint error (#1858)
    
    * Apply Emma's feedback from review (#1848)
    
    * Remove refs to national_df (#1848)
    
    * Account for new, fake nullable bools in tiles (#1848)
    
    To handle a geojson limitation, Emma converted some nullable boolean
    colunms to float64 in the tiles export with the values {0.0, 1.0, nan},
    giving us the same expressiveness. Sadly, this broke my assumption that
    all columns between the score and tiles csvs would have the same dtypes,
    so I need to account for these new, fake bools in my test.
    
    * Use equals instead of my worse version (#1848)
    
    * Missed a spot where we called _create_score_data (#1848)
    
    * Update per safety (#1848)
    
    Co-authored-by: matt bowen <[email protected]>
    emma-nechamkin and mattbowen-usds committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    9c0e199 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Add tests to make sure each source makes it to the score correctly (#…

    …1878)
    
    * Remove unused persistent poverty from score (#1835)
    
    * Test a few datasets for overlap in the final score (#1835)
    
    * Add remaining data sources (#1853)
    
    * Apply code-review feedback (#1835)
    
    * Rearrange a little for readabililty (#1835)
    
    * Add tract test (#1835)
    
    * Add test for score values (#1835)
    
    * Check for unmatched source tracts (#1835)
    
    * Cleanup numeric code to plaintext (#1835)
    
    * Make import more obvious (#1835)
    mattbowen-usds committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d41153d View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Updating traffic barriers to include low pop threshold (#1889)

    Changing the traffic barriers to only be included for places with recorded population
    emma-nechamkin committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    426328e View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Remove no land tracts from map (#1894)

    remove from map
    emma-nechamkin committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    fb4c484 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Issue 1831: missing life expectancy data from Maine and Wisconsin (#1887

    )
    
    * Fixing missing states and adding tests for states to all classes
    lucasmbrown-usds committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    6e9c44e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Removing low pop tracts from FEMA population loss (#1898)

    dropping 0 population from FEMA
    emma-nechamkin committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    60164c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. 1831 Follow up (#1902)

    This code causes no functional change to the code. It does two things:
    
    1. Uses difference instead of - to improve code style for working with sets.
    
    2. Removes the line EXPECTED_MISSING_STATES = ["02", "15"], which is now redundant because of the line I added (in a previous pull request) of ALASKA_AND_HAWAII_EXPECTED_IN_DATA = False.
    lucasmbrown-usds committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    4d02525 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Add tests for all non-census sources (#1899)

    * Refactor CDC life-expectancy (1554)
    
    * Update to new tract list (#1554)
    
    * Adjust for tests (#1848)
    
    * Add tests for cdc_places (#1848)
    
    * Add EJScreen tests (#1848)
    
    * Add tests for HUD housing (#1848)
    
    * Add tests for GeoCorr (#1848)
    
    * Add persistent poverty tests (#1848)
    
    * Update for sources without zips, for new validation (#1848)
    
    * Update tests for new multi-CSV but (#1848)
    
    Lucas updated the CDC life expectancy data to handle a bug where two
    states are missing from the US Overall download. Since virtually none of
    our other ETL classes download multiple CSVs directly like this, it
    required a pretty invasive new mocking strategy.
    
    * Add basic tests for nature deprived (#1848)
    
    * Add wildfire tests (#1848)
    
    * Add flood risk tests (#1848)
    
    * Add DOT travel tests (#1848)
    
    * Add historic redlining tests (#1848)
    
    * Add tests for ME and WI (#1848)
    
    * Update now that validation exists (#1848)
    
    * Adjust for validation (#1848)
    
    * Add health insurance back to cdc places (#1848)
    
    Ooops
    
    * Update tests with new field (#1848)
    
    * Test for blank tract removal (#1848)
    
    * Add tracts for clipping behavior
    
    * Test clipping and zfill behavior (#1848)
    
    * Fix bad test assumption (#1848)
    
    * Simplify class, add test for tract padding (#1848)
    
    * Fix percentage inversion, update tests (#1848)
    
    Looking through the transformations, I noticed that we were subtracting
    a percentage that is usually between 0-100 from 1 instead of 100, and so
    were endind up with some surprising results. Confirmed with lucasmbrown-usds
    
    * Add note about first street data (#1848)
    mattbowen-usds committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    876655d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Issue 1900: Tribal overlap with Census tracts (#1903)

    * working notebook
    
    * updating notebook
    
    * wip
    
    * fixing broken tests
    
    * adding tribal overlap files
    
    * WIP
    
    * WIP
    
    * WIP, calculated count and names
    
    * working
    
    * partial cleanup
    
    * partial cleanup
    
    * updating field names
    
    * fixing bug
    
    * removing pyogrio
    
    * removing unused imports
    
    * updating test fixtures to be more realistic
    
    * cleaning up notebook
    
    * fixing black
    
    * fixing flake8 errors
    
    * adding tox instructions
    
    * updating etl_score
    
    * suppressing warning
    
    * Use projected CRSes, ignore geom types (#1900)
    
    I looked into this a bit, and in general the geometry type mismatch
    changes very little about the calculation; we have a mix of
    multipolygons and polygons. The fastest thing to do is just not keep
    geom type; I did some runs with it set to both True and False, and
    they're the same within 9 digits of precision. Logically we just want to
    overlaps, regardless of how the actual geometries are encoded between
    the frames, so we can in this case ignore the geom types and feel OKAY.
    
    I also moved to projected CRSes, since we are actually trying to do area
    calculations and so like, we should. Again, the change is small in
    magnitude but logically more sound.
    
    * Readd CDC dataset config (#1900)
    
    * adding comments to fips code
    
    * delete unnecessary loggers
    
    Co-authored-by: matt bowen <[email protected]>
    lucasmbrown-usds and mattbowen-usds committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    aca2261 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Improve score test documentation based on Lucas's feedback (#1835) (#…

    …1914)
    
    * Better document base on Lucas's feedback (#1835)
    
    * Fix typo (#1835)
    
    * Add test to verify GEOJSON matches tiles (#1835)
    
    * Remove NOOP line (#1835)
    
    * Move GEOJSON generation up for new smoketest (#1835)
    
    * Fixup code format (#1835)
    
    * Update readme for new somketest (#1835)
    mattbowen-usds committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    f70f30d View commit details
    Browse the repository at this point in the history
  2. Cleanup source tests (#1912)

    * Move test to base for broader coverage (#1848)
    
    * Remove duplicate line (#1848)
    
    * FUDS needed an extra mock (#1848)
    mattbowen-usds committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    d8dd4cf View commit details
    Browse the repository at this point in the history
  3. Add tribal count notebook (#1917) (#1919)

    * Add tribal count notebook (#1917)
    
    * test without caching
    
    * added comment
    
    Co-authored-by: lucasmbrown-usds <[email protected]>
    mattbowen-usds and lucasmbrown-usds committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    6e0ef33 View commit details
    Browse the repository at this point in the history
  4. Add tribal overlap to downloads (#1907)

    * Add tribal data to downloads (#1904)
    
    * Update test pickle with current cols (#1904)
    
    * Remove text of tribe names from GeoJSON (#1904)
    
    * Update test data (#1904)
    
    * Add tribal overlap to smoketests (#1904)
    mattbowen-usds committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9e85375 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Issue 1910: Do not impute income for 0 population tracts (#1918)

    * should be working, has unnecessary loggers
    
    * removing loggers and cleaning up
    
    * updating ejscreen tests
    
    * adding tests and responding to PR feedback
    
    * fixing broken smoke test
    
    * delete smoketest docs
    lucasmbrown-usds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    9fb9874 View commit details
    Browse the repository at this point in the history
  2. updating click

    esfoobar-usds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    15d946c View commit details
    Browse the repository at this point in the history
  3. updating click

    esfoobar-usds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2f61900 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    48d961b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4da55a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Update deps safety says are vulnerable (#1937) (#1938)

    Co-authored-by: matt bowen <[email protected]>
    mattbowen-usds and matt bowen committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    0f0d6db View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Add demos for island areas (#1932)

    * Backfill population in island areas (#1882)
    
    * Update smoketest to account for backfills (#1882)
    
    As I wrote in the commend:
    We backfill island areas with data from the 2010 census, so if THOSE tracts
    have data beyond the data source, that's to be expected and is fine to pass.
    If some other state or territory does though, this should fail
    
    This ends up being a nice way of documenting that behavior i guess!
    
    * Fixup lint issues (#1882)
    
    * Add in race demos to 2010 census pull (#1851)
    
    * Add backfill data to score (#1851)
    
    * Change column name (#1851)
    
    * Fill demos after the score (#1851)
    
    * Add income back, adjust test (#1882)
    
    * Apply code-review feedback (#1851)
    
    * Add test for island area backfill (#1851)
    
    * Fix bad rename (#1851)
    mattbowen-usds committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    8e5ed5b View commit details
    Browse the repository at this point in the history
  2. Reorder download fields, add plumbing back (#1942)

    * Add back lack of plumbing fields (#1920)
    
    * Reorder fields for excel (#1921)
    
    * Reorder excel fields (#1921)
    
    * Fix formating, lint errors, pickes (#1921)
    
    * Add missing plumbing col, fix order again (#1921)
    
    * Update that pickle (#1921)
    mattbowen-usds committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    247db4a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Configuration menu
    Copy the full SHA
    f4adf17 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Configuration menu
    Copy the full SHA
    f284d75 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4d72c8 View commit details
    Browse the repository at this point in the history
  3. wip on ETL

    lucasmbrown-usds committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    7ceab51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a3ad7e0 View commit details
    Browse the repository at this point in the history
  5. adding todos

    lucasmbrown-usds committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9f0918d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed364fb View commit details
    Browse the repository at this point in the history
  7. fixing pylint error

    lucasmbrown-usds committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a6ba9f6 View commit details
    Browse the repository at this point in the history
  8. wip

    lucasmbrown-usds committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a7a4df0 View commit details
    Browse the repository at this point in the history
  9. renaming

    lucasmbrown-usds committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f080464 View commit details
    Browse the repository at this point in the history
  10. pynb

    lucasmbrown-usds committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    bfb08e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    74bf497 View commit details
    Browse the repository at this point in the history