Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Make code structure less shitty #2

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

hariamoor-zz
Copy link
Collaborator

@hemangandhi suggested a much better code structure for the sandbox module here. I introduce this separate PR for it, because it's out of the scope of #1.

For reference:

I think it'd make more sense if the python code used to run the sandboxes and the dockerfiles were separated from the project root. Perhaps like:

  • projects: the root for all the project templates
    • test_go: the go code and Dockerfile
    • test_python: the python code (though I don't think this is the code you have -- probably another main function) and dockerfile
  • lib (or something -- whatever pip convention dictates): to contain the python library
    • sandbox.py
  • test: the tests for the sandbox library

I guess I have https://realpython.com/python-application-layouts/#installable-single-package in mind with an extra dir for the project roots. I think that dockerfiles can reference each other, so duplication shouldn't be an issue if the projects get larger.

Copy link

@hemangandhi hemangandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done?

Part of the concern was about why the dockerfiles and project code were in separate places and this doesn't resolve that since the dockerfiles and project roots are still separate. Is there a reason for this separation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants