feat(smart-contracts): owners count excludes the zero address #14828
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemsos
changed the title
|
Thanks! Also I think we should make it possible for the zero address to own more than the limit of token per address? |
clemsos
commented
Oct 9, 2024
| @@ -204,7 +204,7 @@ contract MixinKeys is MixinErrors, MixinLockCore { | |||
| _keys[tokenId] = Key(tokenId, expirationTimestamp); | |||
|
|
|||
| // increase total number of unique owners | |||
| if (totalKeys(_recipient) == 0) { | |||
| if (totalKeys(_recipient) == 0 && _recipient != address(0)) { | |||
There was a problem hiding this comment.
this may never actually happen as INVALID_ADDRESS is thrown when a key is created to the null address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a key is transferred to the zero address, the counter of unique owner should decrease
Issues
Fixes #13685
Refs #
Checklist:
Release Note Draft Snippet