Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(unlock-app): Migrate Demo page to app router #14818

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feature(unlock-app): Migrate Demo page to app router #14818

merged 2 commits into from
Oct 7, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Oct 7, 2024 •
edited
Loading

Description

This PR introduces the migration of the demo page from the pages directory to the app router.

Issues

Fixes #
Refs #13673

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 October 7, 2024 10:34
@cla-bot cla-bot bot added the cla-signed label Oct 7, 2024
@0xTxbi 0xTxbi merged commit 013355a into unlock-protocol:master Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xTxbi @julien51