fix: Do not run empty process lists (#691)

Reviewed-by: Jakub Ciolek <[email protected]> Approved-by: Jakub Ciolek <[email protected]>
unikraft · Aug 25, 2023 · f6ae3a5 · f6ae3a5
2 parents c8d847c + c712f5a
commit f6ae3a5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/cmd/kraft/pkg/pkg.go b/cmd/kraft/pkg/pkg.go
@@ -229,6 +229,19 @@ func (opts *Pkg) Run(cmd *cobra.Command, args []string) error {
 		}
 	}
 
+	if len(tree) == 0 {
+		switch true {
+		case len(opts.Target) > 0:
+			return fmt.Errorf("no matching targets found for: %s", opts.Target)
+		case len(opts.Architecture) > 0 && len(opts.Platform) == 0:
+			return fmt.Errorf("no matching targets found for architecture: %s", opts.Architecture)
+		case len(opts.Architecture) == 0 && len(opts.Platform) > 0:
+			return fmt.Errorf("no matching targets found for platform: %s", opts.Platform)
+		default:
+			return fmt.Errorf("no matching targets found for: %s/%s", opts.Platform, opts.Architecture)
+		}
+	}
+
 	model, err := processtree.NewProcessTree(
 		ctx,
 		[]processtree.ProcessTreeOption{

diff --git a/tui/processtree/processtree.go b/tui/processtree/processtree.go
@@ -6,6 +6,7 @@ package processtree
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"strings"
 	"time"
@@ -77,6 +78,10 @@ type ProcessTree struct {
 }
 
 func NewProcessTree(ctx context.Context, opts []ProcessTreeOption, tree ...*ProcessTreeItem) (*ProcessTree, error) {
+	if len(tree) == 0 {
+		return nil, fmt.Errorf("cannot instantiate process tree without sub processes")
+	}
+
 	pt := &ProcessTree{
 		tree:     tree,
 		ctx:      ctx,