Add unauthorised200 parameter to /user endpoint #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1763 +/- ##
==========================================
+ Coverage 61.47% 65.06% +3.59%
==========================================
Files 132 140 +8
Lines 2998 3521 +523
Branches 715 785 +70
==========================================
+ Hits 1843 2291 +448
- Misses 1151 1158 +7
- Partials 4 72 +68 ☔ View full report in Codecov by Sentry. |
paskal
force-pushed
the
paskal/improve_get_user
branch
from
6ad5bec
to
52a9ab7
Compare
akellbl4
requested changes
May 2, 2024
paskal
force-pushed
the
paskal/improve_get_user
branch
from
52a9ab7
to
e189877
Compare
Pull Request Test Coverage Report for Build 9060885089Details
💛 - Coveralls |
esev
reviewed
Jun 29, 2024
| @@ -291,10 +291,17 @@ func (s *Rest) routes() chi.Router { | |||
| rauth.Use(middleware.Timeout(30 * time.Second)) | |||
| rauth.Use(tollbooth_chi.LimitHandler(tollbooth.NewLimiter(10, nil))) | |||
| rauth.Use(authMiddleware.Auth, matchSiteID, middleware.NoCache, logInfoWithBody) | |||
| rauth.Get("/user", s.privRest.userInfoCtrl) | |||
There was a problem hiding this comment.
Could this line be moved into the open routes group of handlers above, rather than creating a new group for it?
| user := rest.MustGetUserInfo(r) | ||
| user, err := rest.GetUserInfo(r) | ||
| if err != nil { | ||
| if r.URL.Query().Get("unauthorised200") == "true" { |
There was a problem hiding this comment.
Is the unauthorised200 parameter necessary? It looks like the frontend code will already accept a 200 response with null as the JSON response.
Please correct me if I'm wrong, I'm new here, but I think if null can be returned here, it looks like no frontend changes would be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1188 without making extra HTTP calls by adding a new parameter to the /api/v1/user endpoint.
Continuation of accidentally closed #1752.