Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pagination to GET /api/v1/find endpoint #1699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add pagination to GET /api/v1/find endpoint #1699

wants to merge 2 commits into from

Commits on Mar 4, 2024

  1. collect /find Info for tree and plain types consistently 

    MakeTree calculated Info locally for historical reasons,
and the results were consistent with the dataService.Info call
but calculated differently.

That change fixes that, ensuring that Info is requested
in the same manner.
    @paskal
    paskal committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a6f3b7e View commit details
    Browse the repository at this point in the history

  2. add pagination to GET /api/v1/find endpoint 

    `format=tree` pagination provides top-level comments with all replies
and returns the last top-level comment as `last_comment` to be used
as `offset` for the next page. If comments and replies overflow
the limit, the one stepping out of the limit will not be returned.
 If the first comment and its replies after the given offset overflow
 the limit, it will be returned with all the replies.

`format=plain` pagination works by providing all comments and returning
the last comment as `last_comment` to be used as `offset`
for the next page.
    @paskal
    paskal committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    4bbb980 View commit details
    Browse the repository at this point in the history