clarify frontend files cache policy #1592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
requested changes
Feb 13, 2023
There was a problem hiding this comment.
It overrides other parts of code which makes this change really confusing and hard to debug. #556 (comment)
Previously Cache-Control was set to "max-age=3600, no-cache", but max-age is not used in case no-cache is set.
paskal
force-pushed
the
paskal/clarify_cache_for_frontend
branch
from
62e6e1e
to
7cc7ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Cache-Control was set to "max-age=3600, no-cache", but max-age is not used in case no-cache is set.
cc @Ivan-Chupin for review.
Addresses #1549 (reply in thread).