Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count for redis_egress sg rule #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IrmantasMarozas
Copy link
Contributor

@IrmantasMarozas IrmantasMarozas commented Apr 21, 2023

Description

Fix count for redis_egress sg rule

I'm not sure why, but pre-commit hook for docs didn't work for me, so I commented it out.

Terraform docs...........................................................Failed

  • hook id: terraform_docs
  • exit code: 1
  • files were modified by this hook

@Ohid25 Ohid25 self-requested a review August 15, 2023 13:03
@Ohid25 Ohid25 added bug Something isn't working question Further information is requested labels Aug 15, 2023
@Ohid25
Copy link
Contributor

Ohid25 commented Aug 15, 2023

Has this been validated using one of the examples?

I tried running this change against one of the examples and I got

❯ terraform validate
╷
│ Error: Incorrect attribute value type
│
│   on ../../main.tf line 142, in resource "aws_security_group_rule" "redis_egress":
│  142:   cidr_blocks       = var.egress_cidr_blocks[count.index]
│     ├────────────────
│     │ count.index is a number
│     │ var.egress_cidr_blocks is a list of string
│
│ Inappropriate value for attribute "cidr_blocks": list of string required.

Second, I'm not totally sure what the issue is here in the first place. What is this solution trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Development

Successfully merging this pull request may close these issues.

2 participants