Sectionview: fixed existing example + added extra examples #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Yinzy00 ! 🙌 I'll make sure we get this reviewed as soon as possible! |
sofietoft
added
the
state/needs-investigation
Frost117
reviewed
Oct 1, 2024
14/umbraco-cms/customizing/section-trees/sections/section-view.md
Outdated
Show resolved
Hide resolved
Frost117
reviewed
Oct 3, 2024
| } | ||
| ``` | ||
|
|
||
| **Using TypeScript** |
There was a problem hiding this comment.
@Yinzy00 this section where the manifest file is made with TS, is it implicit that you are using the bundle type?
https://docs.umbraco.com/umbraco-cms/customizing/extending-overview/extension-types/bundle
There was a problem hiding this comment.
I'm not using bundle i'm using entrypoint.
There was a problem hiding this comment.
You want me to clarify more?
There was a problem hiding this comment.
I’ve added more context about the project setup for the example. However, I’m not sure if this belongs on this page since it seems to relate more to entrypoint extensions. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the already existing example which wasn't up to date with the current version of the ManifestSectionView.
I also added a typescript example of how to define the manifest + added a lit component example as reference to the linked element in the manifest.
Type of suggestion
Product & version (if relevant)
V14, v15