Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash calculation for dynamic fee and access list transactions #253

Merged

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Aug 10, 2023

This PR simplifies transaction hash calculation a bit and uses the chain id provided by the hash function parameter, instead the one from the transaction object, since it can be empty.

Also, property-based tests include testing of dynamic fee transactions as well.

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ethgo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 11:16am

@ferranbt ferranbt merged commit c9c19bc into umbracle:main Aug 10, 2023
2 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the feat/dynamic-fee-tx-signing-test branch August 10, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants