Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset ArenaPool after use #250

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

jp-imx
Copy link
Contributor

@jp-imx jp-imx commented Aug 3, 2023

I believe we are hitting a memory leak in fastjson discussed here: valyala/fastjson#24

This PR resets the fastjson.ArenaPool object after using it. It means we won't get cache hits across calls to MarshalJSON but given the cardinality of the data in blocks and transactions, I expect the impact to be minimal.

Happy to discuss if my assumption if incorrect.

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ethgo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 5:11am

@ferranbt ferranbt merged commit 3fac12f into umbracle:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants