Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [Issue 13] Remove unused imports and code. #1348

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

amaa-99
Copy link

@amaa-99 amaa-99 commented Aug 19, 2023

Removed some of the unused imports and code.

@ukanth
Copy link
Owner

ukanth commented Aug 19, 2023

Most of the code is used. Not sure what is the purpose of this PR ? Also in few places it replaces Rootshell implementation as well ?

@amaa-99
Copy link
Author

amaa-99 commented Aug 19, 2023

As written on the title, removed unused imports and code.
Developing and bug fixing with tons of dead code around is much harder than necessary, therefore...

@amaa-99
Copy link
Author

amaa-99 commented Aug 19, 2023

I couldn't find the replaced Rootshell implementation... Do you mean the dropping of the (unused) result value assignment at:
Log.i(TAG, "Invoking migration script " + command);
com.topjohnwu.superuser.Shell.cmd(command).exec();
G.hasCopyOldExports(true);

@amaa-99
Copy link
Author

amaa-99 commented Aug 19, 2023

p.s. Again the added 'final' attributes are for development and debugging convenience...

@amaa-99 amaa-99 force-pushed the 13-remove-unused-imports-and-code branch from a51b434 to 6ff4539 Compare September 22, 2023 10:36
Removed some of the unused imports and code.
@amaa-99 amaa-99 force-pushed the 13-remove-unused-imports-and-code branch from 6ff4539 to d80506f Compare September 22, 2023 11:20
@amaa-99
Copy link
Author

amaa-99 commented Sep 22, 2023

Could you please follow-up on this one? I think I've answered all your questions above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants