Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIME-133] default 폴더를 가장 뒤에 오도록 기능 추가 #64

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[LIME-133] default 폴더를 가장 뒤에 오도록 기능 추가 #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .../com/programmers/lime/domains/item/implementation/MemberItemFolderFavoriteInfoReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public class MemberItemFolderFavoriteInfoReader implements IFavoriteReader {
private static final int DEFAULT_IMAGE_SIZE = 3;

private final MemberItemReader memberItemReader;
private static final String DEFAULT_FOLDER_NAME = "default";

/*
*
* folder id 가 null 이면 root folder 를 의미한다.
Expand All @@ -33,17 +35,32 @@ public class MemberItemFolderFavoriteInfoReader implements IFavoriteReader {
* */
@Override
public List<MemberItemFavoriteInfo> readFavorites(final Long folderId, final Long memberId) {

if (folderId != null) {
return Collections.emptyList();
}

List<MemberItemFolder> memberItemFolders = memberItemFolderReader.readMemberItemFoldersByMemberId(memberId);
moveDefaultFolderToEnd(memberItemFolders);

return memberItemFolders.stream()
.map(this::mapToMemberItemObjectInfo)
.toList();
}

private void moveDefaultFolderToEnd(final List<MemberItemFolder> memberItemFolders) {
List<MemberItemFolder> defaultFolders = new ArrayList<>();

memberItemFolders.removeIf(folder -> {
boolean isDefault = DEFAULT_FOLDER_NAME.equals(folder.getName());
if (isDefault) {
defaultFolders.add(folder);
}
return isDefault;
});

memberItemFolders.addAll(defaultFolders);
}
Comment on lines +50 to +62
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5;
default 폴더가 1개가 아니라 여러 개일 가능성도 있어서 List를 사용하신건가요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 맞습니다!
default의 수를 기본적으로 1개를 가정하고 생성, 수정을 관리합니다.
하지만 예외적인 상황이 발생해서 default가 여러개 만들어 졌을 때 다음 시나리오들을 생각했습니다.

  • default가 여러 개 일 때 예외 발생하고 예외 메시지 반환 
  • default 폴더들을 모두 뒤로 보내고 반환

만약 예외 메시지를 반환하면 관리자에 의해 중복된 default 폴더가 삭제 될 때 까지 아무것도 할 수 없기 때문에 이렇게 구현하였습니다.


@Override
public FavoriteType getFavoriteType() {
return FavoriteType.FOLDER;
Expand Down
Loading