Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long forecast SFS Regression Test #2478

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

LarissaReames-NOAA
Copy link

@LarissaReames-NOAA LarissaReames-NOAA commented Oct 22, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

I've added a new RT for a long forecast (360 days) of the SFS configuration. To enable this (and avoid the problems discovered in #2320), CICE_PIO is now configurable at compile time instead of hard-coded in CICE-interface/CMakeLists.txt as a cmake flag DCICE_PIO. The default remains "PIO" which is how it was hard-coded previously.

Full RT suite completed on Hera. See log here: /scratch1/BMC/gsd-fv3/Larissa.Reames/ufs-weather-model/tests/logs/log_hera_save/workflow.log

Commit Message:

* UFSWM - Added long SFS RT. Made CICE_PIO configurable at compile time but maintains default "PIO" behavior.

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

  • PR Adds New Tests/Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@LarissaReames-NOAA LarissaReames-NOAA marked this pull request as ready for review October 22, 2024 15:39
@LarissaReames-NOAA LarissaReames-NOAA marked this pull request as draft October 22, 2024 15:40
Comment on lines +50 to +52
OCN_tasks=$OCN_tasks_cpl_bmrk
ICE_tasks=$ICE_tasks_cpl_bmrk
WAV_tasks=0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LarissaReames-NOAA you may want to export these. If I understand, turning off wave is cheaper but then this configuration is more of a nowave_noaero test

It may also be worth adding more files to the baseline in LIST_FILES (CICE, history files,...) if this would be running anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CICE PIO compile optionally replaceable by NetCDF compile in RTs
2 participants