[OS-598] Doctorate checklist > add the fac decision tab #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcougnaud
commented
Sep 26, 2024
There was a problem hiding this comment.
Les changements dans la décision FAC ont impacté la décision SIC mais pour éviter d'avoir à modifier dans cette PR, tout ce qui est lié à la décision SIC, j'ai simplement retiré temporairement les tests.
There was a problem hiding this comment.
Parlons-nous vraiment de décision FAC dans doctorat?
Ce n'est pas plutot décision CDD ?
jcougnaud
force-pushed
the
feature/OS-598
branch
from
d459b28
to
7f19138
Compare
BenJneB
reviewed
Sep 30, 2024
Comment on lines
-85
to
+90
| autres_motifs_refus: List[str] | ||
| class ShouldSpecifierInformationsAcceptationParSIC(BusinessValidator): | ||
| nombre_annees_prevoir_programme: Optional[int] | ||
|
|
||
| def validate(self, *args, **kwargs): | ||
| if not self.motifs_refus and not self.autres_motifs_refus: | ||
| raise MotifRefusFacultaireNonSpecifieException | ||
| if not self.nombre_annees_prevoir_programme: | ||
| raise InformationsAcceptationSICNonSpecifieesException | ||
|
|
||
|
|
||
| @attr.dataclass(frozen=True, slots=True) | ||
| class ShouldSpecifierInformationsAcceptationFacultaire(BusinessValidator): | ||
| avec_conditions_complementaires: Optional[bool] | ||
| conditions_complementaires_existantes: List[ConditionComplementaireApprobationIdentity] | ||
| conditions_complementaires_libres: List[ConditionComplementaireLibreApprobation] | ||
|
|
||
| avec_complements_formation: Optional[bool] | ||
| complements_formation: Optional[List[ComplementFormationIdentity]] | ||
|
|
||
| nombre_annees_prevoir_programme: Optional[int] | ||
|
|
||
| def validate(self, *args, **kwargs): | ||
| if ( | ||
| self.avec_conditions_complementaires is None | ||
| or self.avec_conditions_complementaires | ||
| and not (self.conditions_complementaires_libres or self.conditions_complementaires_existantes) | ||
| or not self.nombre_annees_prevoir_programme | ||
| ): | ||
| raise InformationsAcceptationFacultaireNonSpecifieesException | ||
|
|
||
|
|
||
| @attr.dataclass(frozen=True, slots=True) | ||
| class ShouldSpecifierInformationsAcceptationFacultaireInscription(BusinessValidator): | ||
| avec_conditions_complementaires: Optional[bool] | ||
| conditions_complementaires_existantes: List[ConditionComplementaireApprobationIdentity] | ||
| conditions_complementaires_libres: List[ConditionComplementaireLibreApprobation] | ||
|
|
||
| def validate(self, *args, **kwargs): | ||
| if self.avec_conditions_complementaires and not ( | ||
| self.conditions_complementaires_libres or self.conditions_complementaires_existantes | ||
| ): | ||
| if not self.nombre_annees_prevoir_programme: |
There was a problem hiding this comment.
Ces deux valdateurs sont identiques non ?
BenJneB
reviewed
Sep 30, 2024
| @@ -671,9 +677,102 @@ def clean(self): | |||
| return cleaned_data | |||
|
|
|||
|
|
|||
| class DoctorateFacDecisionApprovalForm(FacDecisionApprovalForm): | |||
| class Meta(FacDecisionApprovalForm.Meta): | |||
| class DoctorateFacDecisionApprovalForm(forms.ModelForm): | |||
There was a problem hiding this comment.
Y'avait rien de réutilisable dans FacDecisionApprovalForm et SIC. ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.