Merge pull request #70 from uclahs-cds/nwiltsie-fix-tests

Catch failing test cases
uclahs-cds · Sep 9, 2024 · 0b97c34 · 0b97c34
2 parents aa3adad + 76d7f19
commit 0b97c34
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ---
 
+## [Unreleased]
+
+### Fixed
+- Properly catch failing test cases
+
 ## [1.1.0] - 2024-07-08
 
 ### Added

diff --git a/nftest/NFTestCase.py b/nftest/NFTestCase.py
@@ -103,8 +103,8 @@ def test(self) -> bool:
             self._logger.info(" [ skipped ]")
             return True
 
-        nextflow_succeeded = self.submit()
-        if not nextflow_succeeded:
+        nextflow_process = self.submit()
+        if nextflow_process.returncode != 0:
             self._logger.error(" [ failed ]")
             return False