Upgrade to latest static analysis Action

[nwiltsie]

This PR replaces the existing CI/CD workflow in this repository with the Action-ified version from tool-static-analysis. Under the hood, the Action is using the exact same docker image to perform the checks, so this upgrade should have no visible change.

Turning the static analysis checks into an Action makes it much easier for your friendly neighborhood Infrastructure Team to make large-scale updates without opening pull requests in dozens or hundreds of repositories.

As an example, 247 workflows across the uclahs-cds organization are using actions/checkout@v2 or actions/checkout@v3. Those will stop working on May 13, 2024. This PR (and its dozens of identical siblings) centralize usage of actions/checkout@v4. In the future, we will only need to update tool-static-analysis in order for all of the repositories updated in this wave to reap the benefits.

[Faizal-Eeman]

This PR (and its dozens of identical siblings) centralize usage of actions/checkout@v4

Did you mean tool-static-analysis@v1?

[Faizal-Eeman]

Looks good to me! Deferring approval to @tyamaguchi-ucla and @yashpatel6.

[nwiltsie]

Did you mean tool-static-analysis@v1?

Both, in a sense - tool-static-analysis@v1 calls actions/checkout@v4 internally.

Per GitHub's advice we're going to keep the v1 tag up-to-date with the latest v1.x.x tag in tool-static-analysis.

If GitHub ever decrees that actions/checkout@v4 needs to be updated, we thus will only need to update it in tool-static-analysis, and then every repo using that action will get it for free.

[nwiltsie]

@Faizal-Eeman Does this make more sense? I've got a template and have another 200 of these to open, so any grammatical updates are welcome:

This PR (and its dozens of identical siblings) centralize usage of tool-static-analysis@v1, which internally uses actions/checkout@v4.

[yashpatel6]

Looks good! Minor question but nothing to block the update

[yashpatel6]

@Faizal-Eeman Does this make more sense? I've got a template and have another 200 of these to open, so any grammatical updates are welcome:

This PR (and its dozens of identical siblings) centralize usage of tool-static-analysis@v1, which internally uses actions/checkout@v4.

Good point on the wording, I do think the above is clearer to avoid any potential confusion about a. why we'd want to centralize the action in general and b. the immediate end of support for certain checkout versions and the fix for it contained within the centralized action

[Faizal-Eeman]

@Faizal-Eeman Does this make more sense? I've got a template and have another 200 of these to open, so any grammatical updates are welcome:

This PR (and its dozens of identical siblings) centralize usage of tool-static-analysis@v1, which internally uses actions/checkout@v4.

Yup, this reads better. Thanks @nwiltsie