Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update M64 resources #300

Merged
merged 9 commits into from
Jul 6, 2024
Merged

update M64 resources #300

merged 9 commits into from
Jul 6, 2024

Conversation

sorelfitzgibbon
Copy link
Contributor

Description

Updated M64.config resource allocations based on results of large sample runs described here

Closes #...

Testing Results

Because this is geared towards running very large samples which can take close to 2 weeks to run, I don't want to test this branch on anything that doesn't need to be run. I don't have any appropriate samples.

Checklist

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have reviewed the Nextflow pipeline standards.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the manifest block in the nextflow.config as part of this pull request; I am listed already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample.

@tyamaguchi-ucla
Copy link
Contributor

@sorelfitzgibbon Thanks! Let me test it out for my large samples.

@tyamaguchi-ucla
Copy link
Contributor

question (non-blocking):
@sorelfitzgibbon @yashpatel6 I just noticed that the template.config has the work_dir param. I thought we've removed this from our NF pipelines to prevent the latency issue a while ago. Is there any reason we want to keep it in the template.config in this pipeline?

@yashpatel6
Copy link
Contributor

question (non-blocking): @sorelfitzgibbon @yashpatel6 I just noticed that the template.config has the work_dir param. I thought we've removed this from our NF pipelines to prevent the latency issue a while ago. Is there any reason we want to keep it in the template.config in this pipeline?

Ah good catch, there shouldn't be any reason to keep that in the template in this pipeline; @sorelfitzgibbon it should be remove-able from the template here?

@sorelfitzgibbon
Copy link
Contributor Author

@sorelfitzgibbon it should be remove-able from the template here?

done

@sorelfitzgibbon sorelfitzgibbon self-assigned this Jun 9, 2024
@tyamaguchi-ucla
Copy link
Contributor

This config finally worked. I'll try other large samples.

Copy link
Contributor

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to process the large samples.

@tyamaguchi-ucla tyamaguchi-ucla merged commit 4d5dd5a into main Jul 6, 2024
8 checks passed
@tyamaguchi-ucla tyamaguchi-ucla deleted the sfitz-update-M64-resources branch July 6, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants