Upgrade to latest static analysis Action #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the outdated CI/CD workflow in this repository with the Action-ified version from tool-static-analysis. The docker image currently used by this repository,
blcdsdockerregistry/cicd-base, was replaced last year byuclahs-cds/docker-CICD-base. Under the hood, the Action is using that updated image to perform the checks.The main branch of this repo has no record of the old workflow being run, but my local tests say it should pass successfully.
Turning the static analysis checks into an Action makes it much easier for your friendly neighborhood Infrastructure Team to make large-scale updates without opening pull requests in dozens or hundreds of repositories.
As an example, 247 workflows across the uclahs-cds organization are using
actions/checkout@v2oractions/checkout@v3. Those will stop working this week. This PR (and its dozens of identical siblings) centralize usage oftool-static-analysis@v1, which internally usesactions/checkout@v4. In the future, we will only need to updatetool-static-analysisin order for all the repositories updated in this wave to reap the benefits.