Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool-Docker-action to v2.1.0 #9

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

nwiltsie
Copy link
Member

This PR updates the tool-Docker-action Action to version 2.1.0. There are a few big changes in this version:

  1. Pushing to any branch foo will build this repository's image and tag it as branch-foo. That tagged image will be removed when the branch is deleted.
  2. By default the Action will only build SemVer tags (e.g. v1.2.3-xxx). Repositories that need to use other kinds of tags (e.g. v1.2beta) can pass the optional non-semver-tags argument; doing so will build all tags that begin with v.

There are a bunch of smaller changes buried in there - you can see them all at this link.

Based on this repository's existing tags, I've determined that it does follow semantic versioning. The updated workflow therefore does not pass the non-semver-tags argument to the Action, although it can be uncommented in the future if need be.

@nwiltsie nwiltsie added the standardization Standardization task label Aug 15, 2024
@nwiltsie
Copy link
Member Author

Hmm, something's wonky here. The image isn't building correctly and I don't think it's related to my changes. @dan-knight can you review the build logs and see if you can figure out the problem?

@dan-knight
Copy link

Weird. The error message isn't super informative, at least to me. @Faizal-Eeman created this image, so I wonder if he knows more about that line.

@Faizal-Eeman
Copy link
Contributor

Hmm, something's wonky here. The image isn't building correctly and I don't think it's related to my changes. @dan-knight can you review the build logs and see if you can figure out the problem?

Created an issue to look into this. #10 (comment)

@Faizal-Eeman Faizal-Eeman self-assigned this Aug 16, 2024
@nwiltsie
Copy link
Member Author

@Faizal-Eeman confirmed that the build issue is unrelated to this change, so I'm going to go ahead and merge this. That will make it much easier to fix, as any new PRs will try to build the image!

Copy link
Contributor

@Faizal-Eeman Faizal-Eeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates in the PR are independent of the CICD error.

This PR can be merged.

@nwiltsie nwiltsie merged commit 5c88898 into main Aug 16, 2024
5 of 6 checks passed
@nwiltsie nwiltsie deleted the nwiltsie_update_docker_action branch August 16, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standardization Standardization task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants