-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update image with R 4.4.0
#6
Conversation
Wiz Scan Summary
|
CHANGELOG.md
Outdated
@@ -8,6 +8,21 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
--- | |||
|
|||
## [Unreleased] | |||
|
|||
--- | |||
## [7.1.0] - 2024-05-06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like our latest is 7.1.1 https://github.com/uclahs-cds/package-BoutrosLab-plotting-general/blob/699233d7e100ee55e52ea51ee713259906e8d809/NEWS#L1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyamaguchi-ucla 7.1.0 is the official release available on GitHub and CRAN. Based on my discussion with Dan 7.1.1 is not out yet as a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason not to release it even though the version bump has occurred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan-knight can provide some insight here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should verify that GPG key fingerprint - that involves setting pipefail
in the shell and then confirming that the fingerprint appears in the gpg --show-keys
output.
@nwiltsie I've added your suggestions. Lmk if I missed anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks ok, a couple of comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @nwiltsie anything else to add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mean to block this PR and feel free to merge this into the main if we need more work to release BPG 7.1.1
.
Thanks Taka. I'll update BPG as soon as |
Description
Update image to latest R
v4.4.0
.Closes #5
Testing Results
Docker Image Testing
docker run
command as described below.My command:
docker run -it --rm -u $(id -u):$(id -g) bpg:7.1.0 bash
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the versioning standards.
I have updated the version number in the
Dockerfile
,README.md
andmetadata.yaml
files.I have updated the dependencies and added my name to the maintainer list in the
Dockerfile
.I have updated the feature changes in the
README.md
(optional).I have added the changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.GitHub Packages Auto Build Rules
I have not manually pushed this Docker image to the uclahs-cds container registry (
ghcr.io/uclahs-cds
) on GitHub.I have updated the
image_name
in themetadata.yaml
which is required by GitHub action to automatically build and push the image.