Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image with R 4.4.0 #6

Merged
merged 14 commits into from
May 15, 2024
Merged

Update image with R 4.4.0 #6

merged 14 commits into from
May 15, 2024

Conversation

Faizal-Eeman
Copy link
Contributor

@Faizal-Eeman Faizal-Eeman commented May 5, 2024

Description

Update image to latest R v4.4.0.

Closes #5

Testing Results

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

My command:

docker run -it --rm -u $(id -u):$(id -g) bpg:7.1.0 bash

groups: cannot find name for group ID 347200513
I have no name!@bafbdc733dc5:/$ 
I have no name!@bafbdc733dc5:/$ 
I have no name!@bafbdc733dc5:/$ R

R version 4.4.0 (2024-04-24) -- "Puppy Cup"
Copyright (C) 2024 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> 
> library("BoutrosLab.plotting.general")
Loading required package: lattice
Loading required package: latticeExtra
Loading required package: cluster
Loading required package: hexbin
Loading required package: grid

Attaching package: 'BoutrosLab.plotting.general'

The following object is masked from 'package:stats':

    dist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number in the Dockerfile, README.md and metadata.yaml files.

  • I have updated the dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the feature changes in the README.md (optional).

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

GitHub Packages Auto Build Rules

  • I have not manually pushed this Docker image to the uclahs-cds container registry (ghcr.io/uclahs-cds) on GitHub.

  • I have updated the image_name in the metadata.yaml which is required by GitHub action to automatically build and push the image.

@wiz-inc-8da00b022c
Copy link

wiz-inc-8da00b022c bot commented May 5, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 2M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 2M 0L 0I
Secrets 0🔑

Dockerfile Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -8,6 +8,21 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
---

## [Unreleased]

---
## [7.1.0] - 2024-05-06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyamaguchi-ucla 7.1.0 is the official release available on GitHub and CRAN. Based on my discussion with Dan 7.1.1 is not out yet as a release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason not to release it even though the version bump has occurred?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-knight can provide some insight here

README.md Show resolved Hide resolved
Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that GPG key fingerprint - that involves setting pipefail in the shell and then confirming that the fingerprint appears in the gpg --show-keys output.

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@Faizal-Eeman
Copy link
Contributor Author

@nwiltsie I've added your suggestions. Lmk if I missed anything!

Copy link

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks ok, a couple of comments:

CHANGELOG.md Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @nwiltsie anything else to add?

@Faizal-Eeman Faizal-Eeman merged commit 5d18120 into main May 15, 2024
5 checks passed
Copy link

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mean to block this PR and feel free to merge this into the main if we need more work to release BPG 7.1.1.

@Faizal-Eeman
Copy link
Contributor Author

I don't mean to block this PR and feel free to merge this into the main if we need more work to release BPG 7.1.1.

Thanks Taka. I'll update BPG as soon as 7.1.1 is out.

@Faizal-Eeman Faizal-Eeman deleted the mmootor-update-bpg-7-1-0 branch May 15, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update R to v4.4.0
4 participants