Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use bl-base for builder and samtools images as base image #5

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

bethneilsen
Copy link
Contributor

@bethneilsen bethneilsen commented Aug 4, 2023

Description

Closes #4 - Updates Dockerfile to use samtools:1.17 as the base image to prevent needing to re-install samtools here

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Hub Auto Build Rules

  • I have created automated build rules following this page and I have not manually pushed this Docker image to the blcdsdockerregistry on Docker Hub.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

Case 1: docker run --rm -u $(id -u):$(id -g) bwa-mem2_samtools-1.17:latest bwa-mem2 version

Case 2: docker run --rm -u $(id -u):$(id -g) bwa-mem2_samtools-1.17:latest samtools version

Testing Results

Case 1:
Launching executable "/usr/local/bin/bwa-mem2.avx512bw"
2.2.1

Case 2:
samtools 1.17
Using htslib 1.17
Copyright (C) 2023 Genome Research Ltd.

Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments:

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment but otherwise looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
bethneilsen and others added 2 commits August 11, 2023 09:46
Imperative tense

Co-authored-by: Yash Patel <[email protected]>
Change SAMTools to SAMtools
@bethneilsen bethneilsen merged commit d9a7bb0 into main Aug 11, 2023
1 check passed
@bethneilsen bethneilsen deleted the bneilsen-Update-To-Use-SAMToolsimage-base branch August 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize by deploying into standalone SAMTools image instead of rebuilding SAMTools
4 participants