Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jaxdf #226

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Updating jaxdf #226

merged 1 commit into from
Dec 18, 2023

Conversation

astanziola
Copy link
Member

@astanziola astanziola commented Dec 18, 2023

This was supposed to be part of jwave 0.2.0 together with many more things, but since the current jwave installation is broken due to the latest jaxdf*, this will be merged in the main branch earlier.

Because this introduces breaking changes, it will still be released as jwave 0.2.0, and the juicy bits will be left for 0.3.0.


*which is still managed by me, I just messed up people, sorry for that... Unfortunately the latest version of plum requires to redefine types, so it is quite tricky to keep backward compatibility

* removed missing function from test_geometry
* added setting class for time domain simulations (TimeWavePropagationSettings )
* upgraded jaxdf
* use jaxdf.Module
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (6884aff) 80.34% compared to head (7d02164) 80.61%.

Files Patch % Lines
jwave/geometry.py 89.18% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   80.34%   80.61%   +0.26%     
==========================================
  Files          14       15       +1     
  Lines        1155     1202      +47     
==========================================
+ Hits          928      969      +41     
- Misses        227      233       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astanziola astanziola merged commit f57eaca into main Dec 18, 2023
8 checks passed
@astanziola astanziola deleted the updated-jaxdf branch January 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant