Pennsylvania state cleaner #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
averyschoen
requested changes
Nov 28, 2023
utils/PA_Data_Web_Scraper.py
Outdated
|
|
||
| years = np.arange(start_year, end_year + 1) | ||
| for year in years: | ||
| link = const.PA_MAIN_URL + const.PA_ZIPPED_URL + str(year) + ".zip" |
There was a problem hiding this comment.
An f-string might look more natural here.
link = f"{const.PA_MAIN_URL}{const.PA_ZIPPED_URL}{year}.zip"
averyschoen
requested changes
Dec 1, 2023
utils/pennsylvania.py
Outdated
| from utils import pennsylvania_helper_functions as helper | ||
| from utils import clean | ||
| import uuid | ||
| # sys.path.append("/home/alankagiri/2023-fall-clinic-climate-cabinet") |
There was a problem hiding this comment.
remove this -- try to use the base path that aicha is using in constants.
trevorspreadbury
added a commit
that referenced
this pull request
Mar 28, 2024
added name to README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.