Added MN util file, updated MN notebook README, uploaded a clean version of MN EDA

[yuzhouw313]

No description provided.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[trevorspreadbury]

I just looked at the utils stuff for code quality. Great job breaking things into small helper functions! Some small areas for improvement

[averyschoen]

Great work! I've left in-line comments to address. Additionally, the branch is failing linter check so please address that.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:28Z
----------------------------------------------------------------

inclear why RegNumb and DonationYear are floats and not ints

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:29Z
----------------------------------------------------------------

add a % here as well

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:30Z
----------------------------------------------------------------

we will need this at some point in the statecleaner class, write a function to drop the non-classifiable data

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:31Z
----------------------------------------------------------------

It does not seem like you are using this anymore, delete it if this is true

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:32Z
----------------------------------------------------------------

if it is going to a PCF show the name of it

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:33Z
----------------------------------------------------------------

just show the plots of 2018->

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:34Z
----------------------------------------------------------------

put a space in the legend title

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

averyschoen commented on 2023-10-31T15:23:35Z
----------------------------------------------------------------

put a space in the legend titles

[averyschoen]

Nice work -- in addition to fixing linter I left a few more in-line comments on the EDA. please combine the MN_exp eda into the MN_eda file and remove the mn_exp_eda file from the repo

[averyschoen]

We will take a look tomorrow at the linter check

updated in new branch