Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the register form to assume DUA consent. #1149

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frankliuao
Copy link

@frankliuao frankliuao commented May 23, 2024

Updating the register form so its asks the user to agree to our DUA when submitting the form. Previously, the form only states that the user is submitting it.

Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/MIDRC-754

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

fence/templates/register_user.html Outdated Show resolved Hide resolved
@@ -15,7 +15,7 @@ <h1>{% block title %}Register{% endblock %}</h1>
{% block content %}
<form method="post">

<h1 class="introduction">Register in order to get access to download data</h1>
<h1 class="introduction">Register* in order to get access to download data</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the asterisk?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment to register.
Comment in <p>.

Copy link
Contributor

@paulineribeyre paulineribeyre May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asterisks make sense when they refer to something else - the paragraph would need to start with an asterisk as well

but here i don't think it's necessary at all, the text is right next to the submit button and visible enough

although it might be better above the button? so you read it before you click submit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Edited.

fence/templates/register_user.html Outdated Show resolved Hide resolved
@@ -30,6 +30,7 @@ <h1 class="introduction">Register in order to get access to download data</h1>
</li>
</ul>
<button class="button-primary-orange" type="submit">Register</button>
<p>By registering and submitting this form, you hereby acknowledge and consent to be bound by our terms and conditions, and our data use agreement (DUA), both of which can be found on our main website, or on our <a href="/dashboard/Public/documentation/DUA.html">data access portal</a>. </p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link directly to the terms and conditions as well? i don't see where the link is on the portal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some terms and conditions are on our main website (www.midrc.org) so it's hard to find a generic url for it. It'll add MIDRC-specific contents to this page which is what I'm trying to avoid. I just checked and I think DUA itself is fine. I've modified it so it only says DUA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants