Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useryaml): upgrade pip, fix installation #63

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/user_yaml_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ jobs:
python-version: 3.9
- name: Install dependencies
run: |
pip install --upgrade pip
pip install gen3users
pip install pyyaml==5.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we use it explicitly in the linting step, i would rather we keep installing it explicitly even if at the moment gen3users already includes it. We can remove the pin though

pip install pyyaml
- name: Checkout, lint and test
run: |
# checkout the code - this supports checking out from a private fork
Expand Down