Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run system updates as root, run user updates for each user #62

Merged
merged 72 commits into from
Sep 17, 2023
Merged

feat: run system updates as root, run user updates for each user #62

merged 72 commits into from
Sep 17, 2023

Conversation

gerblesh
Copy link
Collaborator

@gerblesh gerblesh commented Sep 7, 2023 •
edited
Loading

solves: #5

What's done:

  • Initial work on running updates as different users, getting the users to run updates on
    What needs to be done:
  • Editing the RPM spec
  • Editing the config shipped
  • Coordinating with downstream projects (Bazzite)
  • Documentation on the new changes
  • Document extra config bugs (rpm-ostreed conflicting services)

@gerblesh gerblesh marked this pull request as ready for review September 13, 2023 06:33
@gerblesh
Copy link
Collaborator Author

Currently waiting on bazzite downstream to coordinate a PR before merging

@gerblesh gerblesh marked this pull request as draft September 13, 2023 22:03
@EyeCantCU EyeCantCU mentioned this pull request Sep 15, 2023
Merged
@EyeCantCU
Copy link
Member

Bazzite is good to go!: ublue-os/bazzite#301

gerblesh and others added 23 commits September 15, 2023 08:44
@gerblesh
refactor: split up hardware checks, added memory c
0557d80
@gerblesh
fix: formatting and errors
3248580
@gerblesh
fix(hardware.py): fixed memory check
85de3b3
@gerblesh
fix: change default max_mem_percent to 90.0
35a1c4f
@dependabot @gerblesh
chore(deps): bump sigstore/cosign-installer from 3.1.1 to 3.1.2
44af2b9 
Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@v3.1.1...v3.1.2)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions @gerblesh
chore(main): release 1.2.1
1cdc0f3
@gerblesh
docs: update README
e8f590e
@gerblesh
docs: fix typo in README
72bd8ca
@gerblesh
fix: remove typo in arguments for notify-send
54d92a8
@gerblesh
feat: initial work for running system updates as root, and updates fo…
8d683ad 
…r each user
@gerblesh
fix: add root requirement for running updates
0b54496
@gerblesh
fix: remove home directory configuration, ublue-update is now system-…
03a70eb 
…wide
@gerblesh
chore: move to system service, update spec file and config
936db3f
@gerblesh
chore: remove debug print statements
ab866af
@gerblesh
feat: added --user and --system flags
697a986
@gerblesh
fix: reformat to please the formatting gods
7856d98
@gerblesh
fix: update shellcheck path in RPM spec
3fcefb1
@gerblesh
chore: remove unneeded python deps
e99bb03
@gerblesh
fix: added sudo as a dependency
ac6cf00
@gerblesh
docs: add note about rpm-ostreed config from ublue-os/config
5a97220
@gerblesh
fix: use less sudo, clean up process ee
bdc19c5
@gerblesh
chore: remove useless --user flag
0dcd2e9
@gerblesh
fix: don't run sudo for each script, fixed string formatting
5a28f1f
gerblesh and others added 17 commits September 15, 2023 08:44
@gerblesh
chore: reformat
729f656
@gerblesh
feat: add filelocking to make updates not run at the same time for sa…
28a6e9a 
…me user
@gerblesh
chore: make filelocking use logger
3300803
@gerblesh
chore: remove filelock from pyproject.toml
8931502
@gerblesh
fix: format to please flake8
3287b64
@gerblesh
fix: use user['Name'] instead of user.pw_name
b84e2e3
@gerblesh
docs(README): add troubleshooting section
19a97ed
@gerblesh
fix: formatted code, used f-strings for cmd args
a5ce221
@gerblesh
chore: add debug print statements
4fb47e9
@gerblesh
chore: add more debug print statements
3ee6d7b
@gerblesh
chore: remove error handling for debugging
c0f0856
@EyeCantCU @gerblesh
fix(session): Ensure session type exists before appending active session
53d4b13
@gerblesh
chore: remove check for key
039f104
@gerblesh
chore: add more debug code
96bf4d3
@gerblesh
fix: remove debug code, fixed crash because of keyerror with temporar…
086e027 
…y sessions
@gerblesh
chore: reformat with black
cad419a
@gerblesh
feat(systemd): timing changes
652a29c
@gerblesh gerblesh marked this pull request as ready for review September 15, 2023 16:03
@gerblesh
Copy link
Collaborator Author

merge this PR with: ublue-os/bazzite#301

@gerblesh
Copy link
Collaborator Author

still need to squash!

@EyeCantCU EyeCantCU added this pull request to the merge queue Sep 17, 2023
Merged via the queue into main with commit f67b894 Sep 17, 2023
3 checks passed
@EyeCantCU EyeCantCU deleted the user-system-update branch September 17, 2023 18:04
@gerblesh gerblesh mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akdev1l akdev1l akdev1l approved these changes

@EyeCantCU EyeCantCU EyeCantCU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerblesh @EyeCantCU @akdev1l