Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: made project more modular, added extra inhibitors, improved ask for updates notification #60

Merged
merged 8 commits into from
Sep 5, 2023
Merged

refactor: made project more modular, added extra inhibitors, improved ask for updates notification #60

merged 8 commits into from
Sep 5, 2023

Conversation

gerblesh
Copy link
Collaborator

@gerblesh gerblesh commented Sep 4, 2023

What's in this PR?

  • Made the project more modular
    • split hardware checks into hardware.py
    • split off config logic into config.py
  • Added extra memory hardware check
  • changed config and variable names to be more descriptive
  • Made the notification that asks for updates urgency marked as "critical" so the user knows they need to make a decision before the program closes

@gerblesh gerblesh added this pull request to the merge queue Sep 5, 2023
@gerblesh gerblesh removed this pull request from the merge queue due to a manual request Sep 5, 2023
@gerblesh gerblesh added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 9847bf3 Sep 5, 2023
1 check passed
@gerblesh gerblesh deleted the restructure branch September 5, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EyeCantCU EyeCantCU EyeCantCU approved these changes

@akdev1l akdev1l Awaiting requested review from akdev1l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerblesh @EyeCantCU