Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DX Images #565

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Add DX Images #565

wants to merge 2 commits into from

Conversation

KyleGospo
Copy link
Member

@KyleGospo KyleGospo commented Nov 19, 2023

ARG BASE_IMAGE_NAME="${BASE_IMAGE_NAME}"
ARG FEDORA_MAJOR_VERSION="${FEDORA_MAJOR_VERSION}"

COPY system_files/deck/shared system_files/deck/${BASE_IMAGE_NAME} /
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of copying Deck files, we could move from this being an image target to an option so that DX desktop and DX Deck images can exist separately by adding another build flag that distinguishes itself between standard images and DX images

COPY --from=cgr.dev/chainguard/minio-client:latest /usr/bin/mc /usr/bin/mc

# Install DevPod
RUN rpm-ostree install https://github.com/loft-sh/devpod/releases/download/v0.3.7/DevPod_linux_x86_64.rpm && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I read that this is going to be provided as an AppImage only going into the future with only the CLI being provided as an RPM. We could install the CLI, and then have a dx entry in the portal that provides downloading the AppImage as an option if that sounds all right to you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan was to COPR this one with the intent of seeing if someone can help us get it in fedora.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind looking into throwing it on COPR. I think that's the best bet as it would be nice for it to just be there out of the box

@markob94
Copy link

Any progress on DX version ?

@KyleGospo
Copy link
Member Author

Any progress on DX version ?

Still planned, we'll be returning to this soon

@FlyinPancake
Copy link

Are you guys waiting on some external blockers, or do you need some manpower on this? I can provide the later one :D

@FlyinPancake
Copy link

For the time being I built a "DX" image with bluebuild no nvidia builds yet since I use it on Intel and AMD GPUs however I can add the if someone needs it https://github.com/FlyinPancake/cirrus-os

@@ -0,0 +1,7 @@
if test "$(id -u)" -gt "0" && test -d "$HOME"; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

The issue that ShellCheck is pointing out is that it does not know which shell interpreter you are targeting with your script. ShellCheck needs this information because different shells may have different syntax or support different features. A shebang line at the beginning of your script tells the operating system which interpreter to use when the script is executed, and it also informs ShellCheck which shell to assume when linting the code.

To fix this issue, you should add a shebang line to the top of your script to specify the shell you are using. If you are using Bash, which is common and seems to be the case based on your code, you would add the following line at the very beginning of your script:

Suggested change
if test "$(id -u)" -gt "0" && test -d "$HOME"; then
#!/bin/bash

This comment was generated by an experimental AI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants