Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check foundry builds #711

Merged
merged 3 commits into from
Jul 1, 2023
Merged

fix: check foundry builds #711

merged 3 commits into from
Jul 1, 2023

Conversation

molecula451
Copy link
Member

We'll keep an eye out on this was, the way they release (foundry), it broke the commit hash.

This PR only updates foundry's commit hash

@molecula451 molecula451 changed the title check foundry builds fix: check foundry builds Jul 1, 2023
@rndquu
Copy link
Member

rndquu commented Jul 1, 2023

This PR basically fixes the "Build & Test" workflow, good to merge

@rndquu rndquu self-requested a review July 1, 2023 08:00
@rndquu rndquu merged commit db08bd8 into ubiquity:development Jul 1, 2023
8 of 10 checks passed
@rndquu
Copy link
Member

rndquu commented Jul 1, 2023

@molecula451 next time pls follow conventional commits naming

@nopeless
Copy link
Contributor

nopeless commented Jul 3, 2023

@rndquu Their workflow checks for release hashes, and 31d6498c79af595577f200fc2136b31f43885397 is not a release hash

@molecula451
Copy link
Member Author

molecula451 commented Jul 3, 2023

it was, a few days ago, then it changes and gets lost

@nopeless
Copy link
Contributor

nopeless commented Jul 3, 2023

@molecula451 that shouldn't happen unless they force delete refs. do you think thats the case?

@molecula451
Copy link
Member Author

molecula451 commented Jul 3, 2023

@molecula451 that shouldn't happen unless they force delete refs. do you think thats the case?

that why the issue #715 was opened, to take a look at that until give with the root cause, because we rely on CI, so not trivial, but we need latest foundry, and not any older commit

@nopeless
Copy link
Contributor

nopeless commented Jul 3, 2023

@molecula451 that shouldn't happen unless they force delete refs. do you think thats the case?

that why the issue #715 was opened, to take a look at that until give with the root cause, because we rely on CI, so not trivial, but we need latest foundry, and not any older commit

We may have to ask the foundry maintainers about this. Deleting ref tags is not proper of them. Do you think it might be better to use a stable foundry commit for now?

@molecula451
Copy link
Member Author

We may have to ask the foundry maintainers about this. Deleting ref tags is not proper of them. Do you think it might be better to use a stable foundry commit for now?

This PR set a stable commit, it got lost again, it's been twice, so we'll check that out on, to have a stable commit hash

@nopeless
Copy link
Contributor

nopeless commented Jul 3, 2023

We may have to ask the foundry maintainers about this. Deleting ref tags is not proper of them. Do you think it might be better to use a stable foundry commit for now?

This PR set a stable commit, it got lost again, it's been twice, so we'll check that out on, to have a stable commit hash

By stable, I meant an old commit (>1 month) that will less likely be deleted by any kind of git operations (e.g. rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants