-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check foundry builds #711
Conversation
This PR basically fixes the "Build & Test" workflow, good to merge |
@molecula451 next time pls follow conventional commits naming |
@rndquu Their workflow checks for release hashes, and |
it was, a few days ago, then it changes and gets lost |
@molecula451 that shouldn't happen unless they force delete refs. do you think thats the case? |
that why the issue #715 was opened, to take a look at that until give with the root cause, because we rely on CI, so not trivial, but we need latest foundry, and not any older commit |
We may have to ask the foundry maintainers about this. Deleting ref tags is not proper of them. Do you think it might be better to use a stable foundry commit for now? |
This PR set a stable commit, it got lost again, it's been twice, so we'll check that out on, to have a stable commit hash |
By stable, I meant an old commit (>1 month) that will less likely be deleted by any kind of git operations (e.g. rebase) |
We'll keep an eye out on this was, the way they release (foundry), it broke the commit hash.
This PR only updates foundry's commit hash