Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync-template.yml workflow that synchronizes the repo with ubiquity/ts-template every month #294

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

zyrafal
Copy link

@zyrafal zyrafal commented Sep 8, 2024

@Keyrxng
Copy link
Member

Keyrxng commented Sep 9, 2024

@zyrafal Thanks for the PR!

Could you please take a read through Conventional Commits as this is a standard we use across the org and CI will fail if these standards are not followed.

Please amend your commit title to something like feat: ... or chore: ..., thank you.

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Sep 9, 2024

Copy link
Contributor

github-actions bot commented Sep 9, 2024

@0x4007
Copy link
Member

0x4007 commented Sep 9, 2024

@zyrafal Thanks for the PR!

Could you please take a read through Conventional Commits as this is a standard we use across the org and CI will fail if these standards are not followed.

Please amend your commit title to something like feat: ... or chore: ..., thank you.

This contributor had to update like 10 repositories so we'll let it slide

@Keyrxng
Copy link
Member

Keyrxng commented Sep 9, 2024

@zyrafal Thanks for the PR!
Could you please take a read through Conventional Commits as this is a standard we use across the org and CI will fail if these standards are not followed.
Please amend your commit title to something like feat: ... or chore: ..., thank you.

This contributor had to update like 10 repositories so we'll let it slide

I wasn't aware I thought it was their first PR

@Keyrxng
Copy link
Member

Keyrxng commented Sep 9, 2024

https://github.com/ubq-testing/pay.ubq.fi/pull/3/files

This knocks out a lot of our stuff. build, css, tests, html...

Ideally the only stuff we want to sync is the config files, nothing else

I don't want to merge this until a task has been resolved that accurately ignores everything that we do not want synced.

The workflow appears to process IGNORE_FILES by name, so we'll have to manually specify all of the ignored files, and it also means relative url for each too which is going to be verbose.

Doesn't this introduce the problem where now every x months we need to manually review the ignored files?

Copy link
Member

@Keyrxng Keyrxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes so automated-merging won't do anything but I think it might not do anything anyway because CI has failed but just to be safe.

@0x4007
Copy link
Member

0x4007 commented Sep 10, 2024

https://github.com/ubq-testing/pay.ubq.fi/pull/3/files

This knocks out a lot of our stuff. build, css, tests, html...

Ideally the only stuff we want to sync is the config files, nothing else

I don't want to merge this until a task has been resolved that accurately ignores everything that we do not want synced.

The workflow appears to process IGNORE_FILES by name, so we'll have to manually specify all of the ignored files, and it also means relative url for each too which is going to be verbose.

Doesn't this introduce the problem where now every x months we need to manually review the ignored files?

Reviewing this now. Since this opens a pull request, I believe we only need to fix that pull once. Then it won't attempt to make the same changes again. Not 100% when it comes to git add .

@Keyrxng @whilefoo

@0x4007
Copy link
Member

0x4007 commented Sep 10, 2024

I think lets try and see what happens. The worst it does is open a pull after all. I really hope that next month wont be a mess with bad pulls!

@0x4007 0x4007 merged commit 2413abc into ubiquity:development Sep 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants