Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize tracing span tags with proper error annotation #938

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Standardize tracing span tags with proper error annotation #938

merged 1 commit into from
Aug 16, 2024

Conversation

ChenX1993
Copy link
Contributor

This PR is to fill up tracing gaps in:

  • Standardize the span tags follow OpenTracing semantics conventions
    • Add extra component tag to indicate which library is generating the span
    • Add http status code
    • Add span kind tag to indicate whether span is a client span or server span
    • Update the http url & method tag key
  • Add error tag & span log in order to help with the trace based root cause analysis

@ChenX1993 ChenX1993 merged commit ffabb35 into uber:version-2 Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbhoyar-uber hbhoyar-uber hbhoyar-uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChenX1993 @hbhoyar-uber