Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'sidePadding' property to the treemap #1224

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Bi0max
Copy link

@Bi0max Bi0max commented Jul 25, 2019

We needed to have padding only on the top of the treemap, but it was not possible.
It is useful, when one wants the name of the parent to be seen above the children.
Currently, padding applies from all sides and makes all children components significantly smaller.

So, I decided to add a sidePadding property, so that user can add padding from other sides separately.

'sidePadding' property can be safely used with existing 'padding' property.

Before (with padding=20):
image

After (with padding=3 and sidePadding={'top': 20}):
image

@Bi0max Bi0max changed the title Add 'paddingDirections' property to the treemap Add 'sidePadding' property to the treemap Aug 15, 2019
@Bi0max
Copy link
Author

Bi0max commented Aug 15, 2019

It seems, that build is failed not because of my changes to the code.

@mcnuttandrew
Copy link
Contributor

try rebasing off master i think the build should be fixed now

@Bi0max
Copy link
Author

Bi0max commented Sep 16, 2019

Thank you for letting me know! build works now.

@Bi0max
Copy link
Author

Bi0max commented Nov 27, 2019

Hi guys, do you plan to merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants