Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload artifacts #124

Merged
merged 13 commits into from
Jan 30, 2023
Merged

upload artifacts #124

merged 13 commits into from
Jan 30, 2023

Conversation

isaacbrodsky
Copy link
Collaborator

Attempting to build a workaround for #123 where we instead assemble the final built JAR from artifacts built in the Github Actions pipeline.

@coveralls
Copy link

coveralls commented Jan 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build #365

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.796%
Totals Coverage Status
Change from base Build #351: 0.0%
Covered Lines: 489
Relevant Lines: 490
💛 - Coveralls

nrabinowitz
nrabinowitz approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, though there are some chunks I don't have a lot of expertise in.

src/main/c/h3-java/pull-from-github.sh Show resolved Hide resolved
@isaacbrodsky isaacbrodsky merged commit 321a3f5 into uber:master Jan 30, 2023
@isaacbrodsky isaacbrodsky deleted the upload-artifacts branch January 30, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacbrodsky @coveralls @nrabinowitz