Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching CompleteStartedTask thrift idl #182

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fimanishi
Copy link

Summary

This endpoint will be called by the history service in order to complete a task in matching after it has been replicated in history.
This will allow cadence to actively delete stale tasks from matching on the passive side as these tasks are processed on the active side and replicated, avoiding the large passive side partitions and reducing task processing latency after a failover

Type of Change

  • Add new API(s)
  • Add new data type(s)
  • Add new field(s) to existing data type
  • Remove field(s) from data type
  • Remove data type(s)
  • Remove API(s)
  • Other (please provide detailed description)

Data Effect

  • Does it change the data stored in database?

Detailed Description

Added the CompleteStartedTask endpoint, with the following:

CompleteStartedTaskRequest:

  • domainUUID
  • execution (workflowId, runId)
  • scheduleId

CompleteStartedTaskResponse (no fields)

Impact Analysis

  • Backward Compatibility: new internal API
  • Forward Compatibility: created response for forward compatibility

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?]
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?]
  • Integration Tests: [Do we have integration test covering the change?]
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?]

Rollout Plan

  • What is the rollout plan?
  • Does the order of deployment matter?
  • Is it safe to rollback? Does the order of rollback matter?
  • Is there a kill switch to mitigate the impact immediately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant