Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Vietnamese version] #212

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: [Vietnamese version] #212

merged 1 commit into from
May 28, 2024

Conversation

nc-minh
Copy link
Contributor

@nc-minh nc-minh commented May 26, 2024

Hello to all of you, the creators of this GoLang guide. I come from Vietnam and I have a repository that has been translated from the original version into Vietnamese to serve Vietnamese people who want to learn how Uber has used GoLang.

In this translation, I didn't translate all English words into Vietnamese but still kept some important keywords because they belong to the same language as well as the IT field. And if translated into another language, it would be ambiguous and difficult to understand.

So I want you to add link to my work.

Thank you for reading.

@CLAassistant
Copy link

CLAassistant commented May 26, 2024

CLA assistant check
All committers have signed the CLA.

@mway
Copy link
Member

mway commented May 28, 2024

Hey @nc-minh, thanks for the translation!

The link you're using (https://github.com/nc-minh/uber-go-guide-vi) 404s - is this a private repository? We'll need the link to be working and publicly accessible.

@nc-minh
Copy link
Contributor Author

nc-minh commented May 28, 2024

Hey @nc-minh, thanks for the translation!

The link you're using (https://github.com/nc-minh/uber-go-guide-vi) 404s - is this a private repository? We'll need the link to be working and publicly accessible.

oh sorry I'm sorry. I've already published it.

Copy link
Member

@mway mway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mway mway merged commit 27820cf into uber-go:master May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants