Fix job array display. #1723
Draft
Fix job array display. #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
added
Category:Job Viewer
jpwhite4
force-pushed
the
support_jobarrays
branch
from
d5b8794
to
5229916
Compare
jpwhite4
force-pushed
the
support_jobarrays
branch
2 times, most recently
from
54dd061
to
e00a2a6
Compare
The current code has incomplete support for job arrays - only the primary job identifier is shown. This change adds a new internal parameter called provider_job_id which contains the `job index` for non-array jobs and the `base_job_index[array_index]` for array jobs. There is a corresponding pull request for the xmdod-supremm module and for the xdmod-xsede module that should all be merged at the same time.
jpwhite4
force-pushed
the
support_jobarrays
branch
from
10337be
to
a60611e
Compare
The xdmod-supremm module build has been updated to check for errors/warnings. Needless to say I found some. The default value for the font size must be a numeric string - and not a text string. Add some checks for data validity and hoy out an execption if the checks fail.
jpwhite4
force-pushed
the
support_jobarrays
branch
from
a60611e
to
baa51c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code has incomplete support for job arrays - only the primary job identifier is shown. This change adds a new internal parameter called provider_job_id which contains the
job indexfor non-array jobs and thebase_job_index[array_index]for array jobs.There is a corresponding pull request for the xmdod-supremm module and for the xdmod-xsede module (https://github.com/ubccr/xdmod-xsede/pull/400) that should all be merged at the same time.
before:
after:
note I changed the variable name since the new variable contains something which is semantically different from the old one. Also it makes it easier to find all the places where the code needs to be updated!