Handle REST exceptions for realms that are not configured to provide …

…raw data. (#1894)
ubccr · Aug 7, 2024 · cc7f948 · cc7f948
1 parent cc160a1
commit cc7f948
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/classes/Rest/Controllers/WarehouseControllerProvider.php b/classes/Rest/Controllers/WarehouseControllerProvider.php
@@ -2126,15 +2126,19 @@ private function getUserStore(\XDUser $user, $realm)
      *                                 not included; if an invalid start date,
      *                                 end date, realm, field alias, or filter
      *                                 key is provided; if the end date is
-     *                                 before the start date; or if the offset
-     *                                 is negative.
+     *                                 before the start date; if the offset is
+     *                                 negative; or if the requested realm is
+     *                                 not configured to provide raw data.
      */
     public function getRawData(Request $request, Application $app)
     {
         $user = parent::authenticateToken($request);
         $params = $this->validateRawDataParams($request, $user);
         $realmManager = new RealmManager();
         $queryClass = $realmManager->getRawDataQueryClass($params['realm']);
+        if (!class_exists($queryClass)) {
+            throw new BadRequestHttpException('The requested realm is not configured to provide raw data.');
+        }
         $logger = $this->getRawDataLogger();
         $streamCallback = function () use (
             $user,

diff --git a/tests/integration/lib/Rest/WarehouseControllerProviderTest.php b/tests/integration/lib/Rest/WarehouseControllerProviderTest.php
@@ -830,6 +830,11 @@ public function provideGetRawData()
                 ['realm' => 'foo'],
                 parent::validateBadRequestResponse('Invalid realm.')
             ],
+            [
+                'realm_not_configured',
+                ['realm' => 'Storage'],
+                parent::validateBadRequestResponse('The requested realm is not configured to provide raw data.')
+            ],
             [
                 'invalid_fields',
                 ['fields' => 'foo,bar;'],