pyo3 bindings for uap-python #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Jul 15, 2024
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Jul 15, 2024
Uses ua-parser/uap-rust#3 Fixes ua-parser#166
masklinn
force-pushed
the
pyo3-bindings
branch
16 times, most recently
from
2e03dc7
to
14aaff4
Compare
Advantages ========== - Can do the entire loading in one shot in pure rust from a python iterable. - Work using rust semantics. - Really just works. - Only requires a pyi for type declarations (?). Drawbacks ========= - Likely slower than cffi for pypy, but unlikely to be slower than the slog of pure python. - Graal don't work in tox.
masklinn
force-pushed
the
pyo3-bindings
branch
from
14aaff4
to
ffe4fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tightly bound to cpython, no pypy or other alternate implementations.It looks like pyo3 should support cpyext, so as long as this doesn't use any complicated feature (which it shouldn't) that should work but I can't really find docs so far so TBD. But anyway this should be workable for pypy, and graalpy also claims support for the API version of native packages which supposedly has pyo3 support as well.
So it should be possible to use this for pypy and graal, it might not be as fast as the cpython version but given how ultra slow "pure python" pypy and graal are (ua-parser/uap-python#220) that's likely still a massive gain.