Rename the string regex attribute of matchers to regex
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
force-pushed
the
match-regexes-names
branch
from
0e6a587
to
20d1cd8
Compare
masklinn
changed the title
regex
masklinn
force-pushed
the
match-regexes-names
branch
from
20d1cd8
to
5bf3c7b
Compare
It's kinda dumb that I didn't do that in the first place and I'm not entirely sure why I missed it... Anyway there is no reason to make `pattern` be the string pattern and `regex` be the compiled pattern, that unnecessarily diverges from the regexes.yaml naming for the corresponding attribute which is a shame, and the compiled regex in python is... `re.Pattern`, so it makes more sense on both axis to have `pattern: re.Pattern[str]` and `regex: str`. Also add a `regex_flag` attribute/property on the device matchers for the string version of the flags.
masklinn
force-pushed
the
match-regexes-names
branch
from
5bf3c7b
to
ad01dd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kinda dumb that I didn't do that in the first place and I'm not entirely sure why I missed it...
Anyway there is no reason to make
patternbe the string pattern andregexbe the compiled pattern, that unnecessarily diverges from the regexes.yaml naming for the corresponding attribute which is a shame, and the compiled regex in python is...re.Pattern, so it makes more sense on both axis to havepattern: re.Pattern[str]andregex: str.Also add a
regex_flagattribute/property on the device matchers for the string version of the flags.With that, maybe we could build the matchers straight from the source records by direct unpacking, as well as simplify the codegen through the magic of doing less? This probably requires benching to see if
has the same efficiency as
if it does, then there's no reason to bother with reformatting parser records to the current