Freebsdcpud #289
Open
Freebsdcpud #289
+271
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
binjip978
reviewed
Oct 15, 2024
| }() | ||
|
|
||
| runtime.UnlockOSThread() | ||
| return nil |
There was a problem hiding this comment.
I don't see how this function can return an error. But is this more or less duplicate, I think it's fine.
binjip978
reviewed
Oct 15, 2024
| } | ||
| // If we are here, no matter what they may set, *remote must be true. | ||
| // sadly, cpud -d -remote=true -remote=false ... works. | ||
| *remote = true |
There was a problem hiding this comment.
no sure if I get this, but for me line 69 defines remote value, maybe we should not parse it at all? I mean remove remote = flag.Bool("remote", false, "indicates we are the remote side of the cpu session")
binjip978
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.