Do not allow setting /tmp #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have determined that setting an alternative to /tmp is not as useful as we thought, and it adds more complexity and chances for failure (as this commit shows, actually). This reverts commit 243d03a. Signed-off-by: Ronald G Minnich <[email protected]>
rminnich
force-pushed
the
do-not-allow-setting-/tmp
branch
from
132091f
to
b52eb75
Compare
That commit reads as follows:
Add -tmpMnt to change namespace mount point
Some applications may need to access the original contents in /tmp
directory of the local host. Adding -tmpMnt to allow changing the
private namespace mount point to avoid conflict.
There are a number of problems with this idea, especially as move
to Windows support. Further, it did not really prove to be useful.
This is not exactly a revert, because reverting that commit
was no longer simple, as we have more programs (decpu, decpud)
than we used to.
From here on out, the server's private mounts will be in
only one place: os.TempDir()
Signed-off-by: Ronald G Minnich <[email protected]>
rminnich
force-pushed
the
do-not-allow-setting-/tmp
branch
from
b52eb75
to
6bccd54
Compare
Lencerf
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.