Merge pull request #802 from iRevive/scalafix-rules

Enable additional typelevel-scalafix rules
typelevel · Oct 11, 2024 · 4e699ae · 4e699ae
2 parents 2543ee2 + 2924dcb
commit 4e699ae
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/.scalafix.conf b/.scalafix.conf
@@ -4,6 +4,10 @@ rules = [
   RedundantSyntax
   TypelevelUnusedIO
   TypelevelMapSequence
+  TypelevelAs
+  TypelevelUnusedShowInterpolator
+  TypelevelFs2SyncCompiler
+  TypelevelHttp4sLiteralsSyntax
 ]
 
 OrganizeImports {

diff --git a/core/trace/src/main/scala/org/typelevel/otel4s/trace/SpanContext.scala b/core/trace/src/main/scala/org/typelevel/otel4s/trace/SpanContext.scala
@@ -203,7 +203,7 @@ object SpanContext {
 
   implicit val spanContextShow: Show[SpanContext] =
     Show.show { ctx =>
-      show"SpanContext{" +
+      "SpanContext{" +
         show"traceId=${ctx.traceIdHex}, " +
         show"spanId=${ctx.spanIdHex}, " +
         show"traceFlags=${ctx.traceFlags}, " +

diff --git a/core/trace/src/test/scala/org/typelevel/otel4s/trace/SpanContextSuite.scala b/core/trace/src/test/scala/org/typelevel/otel4s/trace/SpanContextSuite.scala
@@ -112,7 +112,7 @@ class SpanContextSuite extends DisciplineSuite {
 
   test("Show[SpanContext]") {
     Prop.forAll(Gens.spanContext) { ctx =>
-      val expected = show"SpanContext{" +
+      val expected = "SpanContext{" +
         show"traceId=${ctx.traceIdHex}, " +
         show"spanId=${ctx.spanIdHex}, " +
         show"traceFlags=${ctx.traceFlags}, " +

diff --git a/sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/data/SpanData.scala b/sdk/trace/src/main/scala/org/typelevel/otel4s/sdk/trace/data/SpanData.scala
@@ -193,7 +193,7 @@ object SpanData {
       val endTimestamp =
         data.endTimestamp.foldMap(ts => show"endTimestamp=$ts, ")
 
-      show"SpanData{" +
+      "SpanData{" +
         show"name=${data.name}, " +
         show"spanContext=${data.spanContext}, " +
         show"parentSpanContext=${data.parentSpanContext}, " +

diff --git a/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/data/SpanDataSuite.scala b/sdk/trace/src/test/scala/org/typelevel/otel4s/sdk/trace/data/SpanDataSuite.scala
@@ -40,7 +40,7 @@ class SpanDataSuite extends DisciplineSuite {
       val endedEpoch = data.endTimestamp.foldMap(ts => show"endTimestamp=$ts, ")
 
       val expected =
-        show"SpanData{" +
+        "SpanData{" +
           show"name=${data.name}, " +
           show"spanContext=${data.spanContext}, " +
           show"parentSpanContext=${data.parentSpanContext}, " +